Media Capabilities: stub implementation of mediaCapabilities.query().

Media Capabilities: stub implementation of mediaCapabilities.query().

Returns an object that agrees with everything.

BUG=690380
Review-Url: https://codereview.chromium.org/2685863004
Cr-Commit-Position: refs/heads/master@{#450509}
Committed: https://chromium.googlesource.com/chromium/src/+/ff0742e6a8b37e90885d1700d625e17a71b44739

[mlamouri (slow - plz ping), 2017-02-12 18:34:52]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 18:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-02-12 18:37:44]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 18:37:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 20:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 20:03:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mlamouri (slow - plz ping), 2017-02-13 11:12:43]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 11:12:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-02-13 11:17:00]

mlamouri@chromium.org changed reviewers:
+ chcunningham@chromium.org

[mlamouri (slow - plz ping), 2017-02-13 11:17:01]

Chris, what do you think of looking into this? If you don't feel like reviewing
Blink code, I can send this to someone else :)

[haraken, 2017-02-13 11:23:31]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-02-13 11:23:32]

Drive-by:

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h
(right):

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h:28:
private:

Remove private.

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.h
(right):

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.h:14: :
public GarbageCollectedFinalized<MediaDecodingAbility>,

Drop Finalized.

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediacapabilities/OWNERS (right):

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapabilities/OWNERS:1:
chcunningham@chromium.org

There's not yet a written rule but I've been trying to not add a person to an
OWNERS file until he/she has committed a certain number of patches to the code
base.

[mlamouri (slow - plz ping), 2017-02-13 11:33:30]

Thanks for the drive-by haraken@. Do you feel comfortable finishing the review?
:)

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h
(right):

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h:28:
private:
On 2017/02/13 at 11:23:31, haraken wrote:
> Remove private.

Oups :)

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.h
(right):

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.h:14: :
public GarbageCollectedFinalized<MediaDecodingAbility>,
On 2017/02/13 at 11:23:32, haraken wrote:
> Drop Finalized.

Oups ^ 2 :)

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediacapabilities/OWNERS (right):

https://codereview.chromium.org/2685863004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapabilities/OWNERS:1:
chcunningham@chromium.org
On 2017/02/13 at 11:23:32, haraken wrote:
> There's not yet a written rule but I've been trying to not add a person to an
OWNERS file until he/she has committed a certain number of patches to the code
base.

Ok. I removed chcunningham@.

I guess you are now on the hook to do the review haraken@ :)

[mlamouri (slow - plz ping), 2017-02-13 11:34:03]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 11:34:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-13 11:57:52]

LGTM

[commit-bot: I haz the power, 2017-02-13 13:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 13:24:22]

Dry run: This issue passed the CQ dry run.

[chcunningham, 2017-02-13 19:31:06]

chcunningham@chromium.org changed reviewers:
+ wolenetz@chromium.org

[chcunningham, 2017-02-13 19:31:07]

Exciting!

+wolenetz for worker question

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h
(right):

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h:26:
DECLARE_VIRTUAL_TRACE();
#include "third_party/WebKit/Source/platform/heap/Visitor.h"

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl
(right):

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl:8:
Exposed=(Window, Worker),
MSE and EME have not been exposed to workers. There is some technical challenge
who's details I forget - perhaps the concern does not apply here (it probably
doesn't since we aren't really invoking the pipeline/decodeing etc...). +
wolenetz to remind me if this will be an issue

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.cpp
(right):

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.cpp:32:
static_cast<NavigatorMediaCapabilities*>(
I notice this comment:

// Supplementable and Supplement instances are meant to be thread local. They
// should only be accessed from within the thread that created them.

Is that restriction still met if someone accesses this API from a worker thread?

[wolenetz, 2017-02-13 22:33:24]

wolenetz@chromium.org changed reviewers:
+ ddorwin@chromium.org, mlamouri@chromium.org

[wolenetz, 2017-02-13 22:33:25]

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl
(right):

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl:8:
Exposed=(Window, Worker),
On 2017/02/13 19:31:07, chcunningham wrote:
> MSE and EME have not been exposed to workers. There is some technical
challenge
> who's details I forget - perhaps the concern does not apply here (it probably
> doesn't since we aren't really invoking the pipeline/decodeing etc...). +
> wolenetz to remind me if this will be an issue

+mlamouri@ and ddorwin@ w.r.t. workers and HTMLMediaElement or EME.
There's a separate workers effort spinning up; I don't know yet if exposing your
API on worker is a potential problem or not.

[mlamouri (slow - plz ping), 2017-02-13 22:58:25]

Will apply the comments tomorrow when at the office.

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h
(right):

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h:26:
DECLARE_VIRTUAL_TRACE();
On 2017/02/13 at 19:31:06, chcunningham wrote:
> #include "third_party/WebKit/Source/platform/heap/Visitor.h"

OK.

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl
(right):

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl:8:
Exposed=(Window, Worker),
On 2017/02/13 at 22:33:24, wolenetz wrote:
> On 2017/02/13 19:31:07, chcunningham wrote:
> > MSE and EME have not been exposed to workers. There is some technical
challenge
> > who's details I forget - perhaps the concern does not apply here (it
probably
> > doesn't since we aren't really invoking the pipeline/decodeing etc...). +
> > wolenetz to remind me if this will be an issue
> 
> +mlamouri@ and ddorwin@ w.r.t. workers and HTMLMediaElement or EME.
> There's a separate workers effort spinning up; I don't know yet if exposing
your API on worker is a potential problem or not.

This isn't implemented for workers. This only means that the interface is
exposed to the worker context but because WorkerNavigator doesn't expose an
object, it's useless. I will update this to remove the exposition.

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.cpp
(right):

https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.cpp:32:
static_cast<NavigatorMediaCapabilities*>(
On 2017/02/13 at 19:31:07, chcunningham wrote:
> I notice this comment:
> 
> // Supplementable and Supplement instances are meant to be thread local. They
> // should only be accessed from within the thread that created them.
> 
> Is that restriction still met if someone accesses this API from a worker
thread?

It wouldn't because workers would have a different instance. Workers do not use
vanilla Navigator.

[mlamouri (slow - plz ping), 2017-02-14 11:46:53]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 11:47:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 11:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 11:50:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mlamouri (slow - plz ping), 2017-02-14 16:33:24]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 16:33:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 18:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 18:48:47]

Dry run: This issue passed the CQ dry run.

[chcunningham, 2017-02-14 19:48:11]

On 2017/02/13 22:58:25, mlamouri wrote:
> Will apply the comments tomorrow when at the office.
> 
>
https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h
> (right):
> 
>
https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h:26:
> DECLARE_VIRTUAL_TRACE();
> On 2017/02/13 at 19:31:06, chcunningham wrote:
> > #include "third_party/WebKit/Source/platform/heap/Visitor.h"
> 
> OK.
> 
>
https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl
> (right):
> 
>
https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl:8:
> Exposed=(Window, Worker),
> On 2017/02/13 at 22:33:24, wolenetz wrote:
> > On 2017/02/13 19:31:07, chcunningham wrote:
> > > MSE and EME have not been exposed to workers. There is some technical
> challenge
> > > who's details I forget - perhaps the concern does not apply here (it
> probably
> > > doesn't since we aren't really invoking the pipeline/decodeing etc...). +
> > > wolenetz to remind me if this will be an issue
> > 
> > +mlamouri@ and ddorwin@ w.r.t. workers and HTMLMediaElement or EME.
> > There's a separate workers effort spinning up; I don't know yet if exposing
> your API on worker is a potential problem or not.
> 
> This isn't implemented for workers. This only means that the interface is
> exposed to the worker context but because WorkerNavigator doesn't expose an
> object, it's useless. I will update this to remove the exposition.
> 
>
https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
> File
>
third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.cpp
> (right):
> 
>
https://codereview.chromium.org/2685863004/diff/100001/third_party/WebKit/Sou...
>
third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.cpp:32:
> static_cast<NavigatorMediaCapabilities*>(
> On 2017/02/13 at 19:31:07, chcunningham wrote:
> > I notice this comment:
> > 
> > // Supplementable and Supplement instances are meant to be thread local.
They
> > // should only be accessed from within the thread that created them.
> > 
> > Is that restriction still met if someone accesses this API from a worker
> thread?
> 
> It wouldn't because workers would have a different instance. Workers do not
use
> vanilla Navigator.

LGTM

[mlamouri (slow - plz ping), 2017-02-14 19:49:09]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-02-14 19:49:11]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2685863004/#ps140001
(title: "oups")

[commit-bot: I haz the power, 2017-02-14 19:49:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 20:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 20:01:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mlamouri (slow - plz ping), 2017-02-14 21:15:25]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-02-14 21:15:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
chcunningham@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2685863004/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-14 21:16:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 23:22:17]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1487106925264490,
"parent_rev": "6f20e71dec40fa752fb16ade304cda16d537bbdd", "commit_rev":
"ff0742e6a8b37e90885d1700d625e17a71b44739"}

[commit-bot: I haz the power, 2017-02-14 23:22:59]

Description was changed from

==========
Media Capabilities: stub implementation of mediaCapabilities.query().

Returns an object that agrees with everything.

BUG=690380
==========

to

==========
Media Capabilities: stub implementation of mediaCapabilities.query().

Returns an object that agrees with everything.

BUG=690380

Review-Url: https://codereview.chromium.org/2685863004
Cr-Commit-Position: refs/heads/master@{#450509}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff0742e6a8b37e90885d1700d625...
==========

[commit-bot: I haz the power, 2017-02-14 23:23:00]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/ff0742e6a8b37e90885d1700d625...