Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2685863002: NTP: Rename mojo methods, fixing a TODO (Closed)

Created:
3 years, 10 months ago by tibell
Modified:
3 years, 10 months ago
Reviewers:
Marc Treib, jam, dcheng
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, donnd+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, darin (slow to review), Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP: Rename mojo methods, fixing a TODO BUG=653373 Review-Url: https://codereview.chromium.org/2685863002 Cr-Commit-Position: refs/heads/master@{#449153} Committed: https://chromium.googlesource.com/chromium/src/+/a28c8e867faf2ff7287cb4655c04813506d3873e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -35 lines) Patch
M chrome/browser/ui/search/search_ipc_router.h View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 7 chunks +13 lines, -15 lines 0 comments Download
M chrome/common/instant.mojom View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tibell
Trivial rename. Needs everyone to rubber-stamp.
3 years, 10 months ago (2017-02-08 04:35:16 UTC) #4
dcheng
rs lgtm for mojo
3 years, 10 months ago (2017-02-08 04:44:21 UTC) #5
Marc Treib
lgtm Thank you for fixing this!
3 years, 10 months ago (2017-02-08 09:17:54 UTC) #8
jam
lgtm
3 years, 10 months ago (2017-02-08 17:09:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685863002/1
3 years, 10 months ago (2017-02-08 23:54:24 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 00:13:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a28c8e867faf2ff7287cb4655c04...

Powered by Google App Engine
This is Rietveld 408576698