'data:' may not be used as a document's base URL.

'data:' may not be used as a document's base URL.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/TsBB5GOpMZA/AAE_Sb_HBwAJ
Spec: https://github.com/whatwg/html/issues/2249

BUG=679318
Review-Url: https://codereview.chromium.org/2685843003
Cr-Commit-Position: refs/heads/master@{#449262}
Committed: https://chromium.googlesource.com/chromium/src/+/60e243955ccc6ac466c074d812ae406dec337fe3

[Mike West, 2017-02-08 15:03:03]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 15:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 15:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 15:05:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Mike West, 2017-02-09 08:11:37]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[Mike West, 2017-02-09 08:11:52]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2017-02-09 08:11:53]

How about this one? The brave new world is a little too brave and new for me. :)

[commit-bot: I haz the power, 2017-02-09 08:12:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-09 08:12:28]

lgtm

[commit-bot: I haz the power, 2017-02-09 08:38:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 08:38:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2017-02-09 10:27:36]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2017-02-09 10:27:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2685843003/#ps40001
(title: "Tests.")

[commit-bot: I haz the power, 2017-02-09 10:27:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 11:57:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486636056664510,
"parent_rev": "eb73e4330ecb59905157b11ce20ca29345d9635e", "commit_rev":
"60e243955ccc6ac466c074d812ae406dec337fe3"}

[commit-bot: I haz the power, 2017-02-09 11:57:36]

Description was changed from

==========
'data:' may not be used as a document's base URL.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/TsBB5GOpMZA/AAE_Sb_H...
Spec: https://github.com/whatwg/html/issues/2249

BUG=679318
==========

to

==========
'data:' may not be used as a document's base URL.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/TsBB5GOpMZA/AAE_Sb_H...
Spec: https://github.com/whatwg/html/issues/2249

BUG=679318

Review-Url: https://codereview.chromium.org/2685843003
Cr-Commit-Position: refs/heads/master@{#449262}
Committed:
https://chromium.googlesource.com/chromium/src/+/60e243955ccc6ac466c074d812ae...
==========

[commit-bot: I haz the power, 2017-02-09 11:57:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/60e243955ccc6ac466c074d812ae...

[Rick Byers, 2017-02-10 14:57:27]

On 2017/02/09 11:57:37, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/60e243955ccc6ac466c074d812ae...

Note that the test changes here were reverted upstream because they don't yet
match the spec.  See https://github.com/whatwg/html/issues/2249

[Rick Byers, 2017-02-10 15:06:07]

Description was changed from

==========
'data:' may not be used as a document's base URL.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/TsBB5GOpMZA/AAE_Sb_H...
Spec: https://github.com/whatwg/html/issues/2249

BUG=679318

Review-Url: https://codereview.chromium.org/2685843003
Cr-Commit-Position: refs/heads/master@{#449262}
Committed:
https://chromium.googlesource.com/chromium/src/+/60e243955ccc6ac466c074d812ae...
==========

to

==========
'data:' may not be used as a document's base URL.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/TsBB5GOpMZA/AAE_Sb_H...
Spec: https://github.com/whatwg/html/issues/2249

BUG=679318

Review-Url: https://codereview.chromium.org/2685843003
Cr-Commit-Position: refs/heads/master@{#449262}
Committed:
https://chromium.googlesource.com/chromium/src/+/60e243955ccc6ac466c074d812ae...
==========

[Rick Byers, 2017-02-10 15:07:02]

On 2017/02/10 14:57:27, Rick Byers wrote:
> On 2017/02/09 11:57:37, commit-bot: I haz the power wrote:
> > Committed patchset #3 (id:40001) as
> >
>
https://chromium.googlesource.com/chromium/src/+/60e243955ccc6ac466c074d812ae...
> 
> Note that the test changes here were reverted upstream because they don't yet
> match the spec.  See https://github.com/whatwg/html/issues/2249

foolip@ - what should our workflow be in cases like this where we've decided to
make a change which hasn't yet landed in the spec?

[foolip, 2017-02-10 22:06:08]

On 2017/02/10 15:07:02, Rick Byers wrote:
> On 2017/02/10 14:57:27, Rick Byers wrote:
> > On 2017/02/09 11:57:37, commit-bot: I haz the power wrote:
> > > Committed patchset #3 (id:40001) as
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/60e243955ccc6ac466c074d812ae...
> > 
> > Note that the test changes here were reverted upstream because they don't
yet
> > match the spec.  See https://github.com/whatwg/html/issues/2249
> 
> foolip@ - what should our workflow be in cases like this where we've decided
to
> make a change which hasn't yet landed in the spec?

In this case I wonder if we couldn't have waited for the spec change to land,
let's discuss on the intent thread.

Still, there will be some cases where we want to change before the spec in order
to try something out first, to prove it web compatible for example. In those
cases, I think we should first try to write tests for the existing spec that we
fail in a way that conclusively shows what our new behavior is. Or if that's too
messy or confusing for a given case, just have the tests outside of
web-platform-tests in the interim, with a TODO or open issue somewhere.