Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2685793004: Chromad: Wire up displayName and givenName (Closed)

Created:
3 years, 10 months ago by Roman Sorokin (ftl)
Modified:
3 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, hashimoto+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromad: Wire up displayName and givenName Send to Chromium displayName and givenName fetched from Active Directory BUG=689000 TEST=manual Review-Url: https://codereview.chromium.org/2685793004 Cr-Commit-Position: refs/heads/master@{#449602} Committed: https://chromium.googlesource.com/chromium/src/+/fc75ccee5fbb2fb80fe9981b38ea122180500c43

Patch Set 1 #

Total comments: 6

Patch Set 2 : Combine SetDisplayName and SetGivenName into SetDisplayAndGiveName #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -21 lines) Patch
M chrome/browser/chromeos/login/app_launch_signin_screen.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 6 chunks +24 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 1 chunk +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download
M chromeos/dbus/auth_policy_client.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chromeos/dbus/auth_policy_client.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_auth_policy_client.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Roman Sorokin (ftl)
Hey Xiyuan, could you PTAL? Thanks!
3 years, 10 months ago (2017-02-08 13:48:38 UTC) #2
xiyuan
https://codereview.chromium.org/2685793004/diff/1/chrome/browser/chromeos/login/existing_user_controller.h File chrome/browser/chromeos/login/existing_user_controller.h (right): https://codereview.chromium.org/2685793004/diff/1/chrome/browser/chromeos/login/existing_user_controller.h#newcode268 chrome/browser/chromeos/login/existing_user_controller.h:268: void ClearRecoredNames(); ClearRecoredNames -> ClearRecor*d*edNames https://codereview.chromium.org/2685793004/diff/1/chrome/browser/chromeos/login/ui/login_display.h File chrome/browser/chromeos/login/ui/login_display.h (right): ...
3 years, 10 months ago (2017-02-08 22:59:57 UTC) #3
Roman Sorokin (ftl)
https://codereview.chromium.org/2685793004/diff/1/chrome/browser/chromeos/login/existing_user_controller.h File chrome/browser/chromeos/login/existing_user_controller.h (right): https://codereview.chromium.org/2685793004/diff/1/chrome/browser/chromeos/login/existing_user_controller.h#newcode268 chrome/browser/chromeos/login/existing_user_controller.h:268: void ClearRecoredNames(); On 2017/02/08 22:59:57, xiyuan wrote: > ClearRecoredNames ...
3 years, 10 months ago (2017-02-09 10:50:47 UTC) #4
xiyuan
lgtm
3 years, 10 months ago (2017-02-09 18:28:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685793004/20001
3 years, 10 months ago (2017-02-10 12:19:36 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 13:17:21 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc75ccee5fbb2fb80fe9981b38ea...

Powered by Google App Engine
This is Rietveld 408576698