Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2685783004: Add EditingStyleUtitilies.{cpp,h} to BUILD.gn (Closed)

Created:
3 years, 10 months ago by joone
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add EditingStyleUtitilies.{cpp,h} to BUILD.gn EditingStyle is used to deal with CSS styles in editing. but it has many static methods to create an EditingStyle and some methods don't access member variables so they could be split into EditingStyleUtilities class. We just copied EditingStyle class and renamed to EditingStyleUtilities class in the previous CL(https://crrev.com/2649613002). This CL only keeps the static methods used to create an EditingStyle and some static methods for utility purpose in EditingStyleUtilities class. The next CL will rename the methods and their call sites. BUG=679817 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2685783004 Cr-Commit-Position: refs/heads/master@{#449238} Committed: https://chromium.googlesource.com/chromium/src/+/b68fa9e4f675ec4f158c40297a5638bbb7089f29

Patch Set 1 : Add EditingStyleUtitilies.{cpp,h} to BUILD.gn #

Total comments: 4

Patch Set 2 : keep the original copyright comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1989 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.h View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyleUtilities.h View 1 2 chunks +9 lines, -210 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp View 1 9 chunks +17 lines, -1775 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
joone
Hi yosin@ could you review this CL?
3 years, 10 months ago (2017-02-08 22:19:31 UTC) #7
yosin_UTC9
https://codereview.chromium.org/2685783004/diff/60001/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp File third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp (right): https://codereview.chromium.org/2685783004/diff/60001/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp#newcode1 third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp:1: // Copyright 2017 The Chromium Authors. All rights reserved. ...
3 years, 10 months ago (2017-02-09 01:21:34 UTC) #10
joone
Thanks for the review! https://codereview.chromium.org/2685783004/diff/60001/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp File third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp (right): https://codereview.chromium.org/2685783004/diff/60001/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp#newcode1 third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp:1: // Copyright 2017 The Chromium ...
3 years, 10 months ago (2017-02-09 04:18:27 UTC) #11
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-09 05:05:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685783004/80001
3 years, 10 months ago (2017-02-09 05:05:29 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 08:39:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b68fa9e4f675ec4f158c40297a56...

Powered by Google App Engine
This is Rietveld 408576698