Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: ui/vector_icons/BUILD.gn

Issue 2685683004: Move more vector icons to more appropriate directories. (Closed)
Patch Set: fix android? Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/vector_icons/BUILD.gn
diff --git a/ui/vector_icons/BUILD.gn b/ui/vector_icons/BUILD.gn
index c299793bdac314f5bbd52448ed92f067a10106c9..44553f42b1b2387bcca365863af37052d3f0b58e 100644
--- a/ui/vector_icons/BUILD.gn
+++ b/ui/vector_icons/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/util/branding.gni")
import("//ui/vector_icons/vector_icons.gni")
aggregate_vector_icons("ui_vector_icons") {
@@ -10,6 +11,19 @@ aggregate_vector_icons("ui_vector_icons") {
icons = [
"close.1x.icon",
"close.icon",
+ "error_circle.icon",
sky 2017/02/13 21:35:38 Why do we have this icons in ui instead of media?
Evan Stade 2017/02/13 21:53:33 Mainly because it's a generic MD icon and therefor
sky 2017/02/13 23:28:43 Sorry for not being clear. I mean all these icons.
Evan Stade 2017/02/13 23:51:47 Which ones do you mean? Location, extension, notif
+ "extension.icon",
+ "location_on.icon",
+ "media_router_active.icon",
+ "media_router_error.icon",
+ "media_router_idle.icon",
+ "media_router_warning.icon",
+ "microphone.icon",
+ "midi.icon",
+ "notifications.icon",
+ "protocol_handler.icon",
+ "videocam.icon",
+ "warning.icon",
]
}

Powered by Google App Engine
This is Rietveld 408576698