Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: ui/vector_icons/BUILD.gn

Issue 2685683004: Move more vector icons to more appropriate directories. (Closed)
Patch Set: fix android? Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2017 The Chromium Authors. All rights reserved. 1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/util/branding.gni")
5 import("//ui/vector_icons/vector_icons.gni") 6 import("//ui/vector_icons/vector_icons.gni")
6 7
7 aggregate_vector_icons("ui_vector_icons") { 8 aggregate_vector_icons("ui_vector_icons") {
8 icon_directory = "." 9 icon_directory = "."
9 10
10 icons = [ 11 icons = [
11 "close.1x.icon", 12 "close.1x.icon",
12 "close.icon", 13 "close.icon",
14 "error_circle.icon",
sky 2017/02/13 21:35:38 Why do we have this icons in ui instead of media?
Evan Stade 2017/02/13 21:53:33 Mainly because it's a generic MD icon and therefor
sky 2017/02/13 23:28:43 Sorry for not being clear. I mean all these icons.
Evan Stade 2017/02/13 23:51:47 Which ones do you mean? Location, extension, notif
15 "extension.icon",
16 "location_on.icon",
17 "media_router_active.icon",
18 "media_router_error.icon",
19 "media_router_idle.icon",
20 "media_router_warning.icon",
21 "microphone.icon",
22 "midi.icon",
23 "notifications.icon",
24 "protocol_handler.icon",
25 "videocam.icon",
26 "warning.icon",
13 ] 27 ]
14 } 28 }
15 29
16 static_library("vector_icons") { 30 static_library("vector_icons") {
17 sources = get_target_outputs(":ui_vector_icons") 31 sources = get_target_outputs(":ui_vector_icons")
18 sources += [ "//ui/gfx/vector_icon_types.h" ] 32 sources += [ "//ui/gfx/vector_icon_types.h" ]
19 33
20 deps = [ 34 deps = [
21 ":ui_vector_icons", 35 ":ui_vector_icons",
22 "//base", 36 "//base",
23 "//skia", 37 "//skia",
24 ] 38 ]
25 } 39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698