Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7048)

Unified Diff: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc

Issue 2685683004: Move more vector icons to more appropriate directories. (Closed)
Patch Set: fix android? Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
index cd97f68e3d5a018257290e59a19567017ac5fe27..9f0dd60344afc58a08f5ee11a641246ce49ae46a 100644
--- a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
@@ -232,11 +232,9 @@ PermissionsBubbleDialogDelegateView::PermissionsBubbleDialogDelegateView(
layout_delegate->GetMetric(
LayoutDelegate::Metric::RELATED_LABEL_HORIZONTAL_SPACING)));
views::ImageView* icon = new views::ImageView();
- gfx::VectorIconId vector_id = requests[index]->GetIconId();
- if (vector_id != gfx::VectorIconId::VECTOR_ICON_NONE) {
- icon->SetImage(
- gfx::CreateVectorIcon(vector_id, kIconSize, gfx::kChromeIconGrey));
- }
+ const gfx::VectorIcon& vector_id = requests[index]->GetIconId();
+ icon->SetImage(
+ gfx::CreateVectorIcon(vector_id, kIconSize, gfx::kChromeIconGrey));
icon->SetTooltipText(base::string16()); // Redundant with the text fragment
label_container->AddChildView(icon);
views::Label* label =

Powered by Google App Engine
This is Rietveld 408576698