Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2685673002: [WPT Export] Add ability to pass GitHub creds as JSON file (Closed)

Created:
3 years, 10 months ago by jeffcarp
Modified:
3 years, 10 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WPT Export] Add ability to pass GitHub creds as JSON file Also rename --user and --token to --gh-user and --gh-token BUG=689295 Review-Url: https://codereview.chromium.org/2685673002 Cr-Commit-Position: refs/heads/master@{#448861} Committed: https://chromium.googlesource.com/chromium/src/+/9373f6486cb4c1d6f7a0f3260d4b5dbccec9a821

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address CL feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M third_party/WebKit/Tools/Scripts/wpt-export View 1 2 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jeffcarp
3 years, 10 months ago (2017-02-07 19:12:25 UTC) #2
qyearsley
LGTM, assuming you've tried out --github-credentials-json once locally to verify that it works. https://codereview.chromium.org/2685673002/diff/1/third_party/WebKit/Tools/Scripts/wpt-export File ...
3 years, 10 months ago (2017-02-07 19:32:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685673002/20001
3 years, 10 months ago (2017-02-08 01:14:28 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 02:21:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9373f6486cb4c1d6f7a0f3260d4b...

Powered by Google App Engine
This is Rietveld 408576698