Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2685663003: [Harmony] Harmonize Chrome OS VPN/Wimax dialogs. (Closed)

Created:
3 years, 10 months ago by xdai1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Harmony] Harmony Chrome OS VPN/Wimax dialogs. No change to the non-Harmony look. BUG=680381 Review-Url: https://codereview.chromium.org/2685663003 Cr-Commit-Position: refs/heads/master@{#449697} Committed: https://chromium.googlesource.com/chromium/src/+/d6cbe1f5574a8ff23a4a1a3570d971679832c017

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -24 lines) Patch
M chrome/browser/chromeos/options/vpn_config_view.cc View 14 chunks +40 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 8 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
xdai1
stevenjb@, ellyjones@, could you help review this CL please? Thanks!
3 years, 10 months ago (2017-02-10 01:31:34 UTC) #3
stevenjb
lgtm
3 years, 10 months ago (2017-02-10 01:40:20 UTC) #5
Elly Fong-Jones
lgtm :)
3 years, 10 months ago (2017-02-10 15:52:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685663003/20001
3 years, 10 months ago (2017-02-10 19:36:27 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:43:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d6cbe1f5574a8ff23a4a1a3570d9...

Powered by Google App Engine
This is Rietveld 408576698