Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2685653003: Reland "Box shadow should be recorded as main thread scrolling reasons for non-root layers." (Closed)

Created:
3 years, 10 months ago by bokan
Modified:
3 years, 10 months ago
Reviewers:
ajuma, yigu, jwd
CC:
chromium-reviews, szager+layoutwatch_chromium.org, asvitkine+watch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, cc-bugs_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Box shadow should be recorded as main thread scrolling reasons for non-root layers." (patchset #2 id:20001 of https://codereview.chromium.org/2676333002/ ) Reason for revert: Reverted patch wasn't responsible for regression. Original issue's description: > Bisect job found this CL several times suspecting that it caused regression on nexus5p(crbug.com/685182). Revert it for now. > > This reverts commit c83ddee4e5dcb0fdce873021c2701c9c3a2c547a. > > BUG= > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2676333002 > Cr-Commit-Position: refs/heads/master@{#448326} > Committed: https://chromium.googlesource.com/chromium/src/+/95d4abb16bc2444b187772d3a4ee461503d4b7a7 TBR=ajuma@chromium.org,jwd@chromium.org,yigu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -23 lines) Patch
M cc/input/main_thread_scrolling_reason.h View 4 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 4 chunks +28 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/two_scrollable_area.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
bokan
Created Revert of Revert "Box shadow should be recorded as main thread scrolling reasons for ...
3 years, 10 months ago (2017-02-07 20:51:31 UTC) #2
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:52:31 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698