Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2685613002: Use toList to copy lists and clean up errors and warnings (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use toList to copy lists and clean up errors and warnings R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/37720f012f62249f6d6d05dfc08c09d9846fc020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -44 lines) Patch
M pkg/analysis_server/lib/src/plugin/result_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_merger.dart View 14 chunks +27 lines, -37 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-07 16:42:30 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-07 16:52:36 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-02-07 17:00:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37720f012f62249f6d6d05dfc08c09d9846fc020 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698