Use toList to copy lists and clean up errors and warnings

pkg/analyzer_plugin/lib/plugin/plugin.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/analysis/byte_store.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart'
     show AnalysisDriverScheduler, PerformanceLog;
 import 'package:analyzer/src/dart/analysis/file_byte_store.dart';
 import 'package:analyzer/src/dart/analysis/file_state.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer_plugin/channel/channel.dart';
 import 'package:analyzer_plugin/protocol/generated_protocol.dart';
 import 'package:analyzer_plugin/protocol/protocol.dart';
 import 'package:analyzer_plugin/protocol/protocol_constants.dart';
 import 'package:analyzer_plugin/src/protocol/protocol_internal.dart';
 import 'package:analyzer_plugin/src/utilities/null_string_sink.dart';
 import 'package:analyzer_plugin/utilities/subscription_manager.dart';
 import 'package:pub_semver/pub_semver.dart';
 
 /**
  * The abstract superclass of any class implementing a plugin for the analysis
  * server.
  *
  * Clients may not implement or mix-in this class, but are expected to extend
  * it.
  */
 abstract class ServerPlugin {
   /**
-   * A gigabyte.
-   */
-  static const int G = 1024 * 1024 * 1024;
-
-  /**
    * A megabyte.
    */
   static const int M = 1024 * 1024;
 
   /**
    * The communication channel being used to communicate with the analysis
    * server.
    */
   PluginCommunicationChannel _channel;
 
@@ skipping 218 matching lines @@
    * Handle a 'plugin.versionCheck' request.
    */
   PluginVersionCheckResult handlePluginVersionCheck(
       Map<String, Object> parameters) {
     String byteStorePath = validateParameter(parameters,
         PLUGIN_REQUEST_VERSION_CHECK_BYTESTOREPATH, 'plugin.versionCheck');
     String versionString = validateParameter(parameters,
         PLUGIN_REQUEST_VERSION_CHECK_VERSION, 'plugin.versionCheck');
     Version serverVersion = new Version.parse(versionString);
     _byteStore =
-        new MemoryCachingByteStore(new FileByteStore(byteStorePath, G), 64 * M);
+        new MemoryCachingByteStore(new FileByteStore(byteStorePath), 64 * M);
     return new PluginVersionCheckResult(
         isCompatibleWith(serverVersion), name, version, fileGlobsToAnalyze,
         contactInfo: contactInfo);
   }
 
   /**
    * Return `true` if this plugin is compatible with an analysis server that is
    * using the given version of the plugin API.
    */
   bool isCompatibleWith(Version serverVersion) =>
@@ skipping 117 matching lines @@
       response = new Response(id,
           error: new RequestError(
               RequestErrorCode.PLUGIN_ERROR, exception.toString(),
               stackTrace: stackTrace.toString()));
     }
     if (response != null) {
       _channel.sendResponse(response);
     }
   }
 }