Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2685603003: test262 roll (Closed)

Created:
3 years, 10 months ago by Dan Ehrenberg
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, binji
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

test262 roll This roll includes the SharedArrayBuffer tests (skipping for now) but doesn't include the $ renaming. This is a reland; previously, I reverted because I was confused about why the rename of $ to $262 didn't break tests; it now seems that the previous patch left it as an alias. This patch does not do the renaming yet, as the renaming usage has not landed upstream yet. R=adamk Review-Url: https://codereview.chromium.org/2685603003 Cr-Commit-Position: refs/heads/master@{#43118} Committed: https://chromium.googlesource.com/v8/v8/+/91b79fb789b120c5e11185ef42cd1b88068de922

Patch Set 1 #

Patch Set 2 : test262 roll #

Patch Set 3 : fix up prune-local-tests.sh and apply #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -56 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
D test/test262/local-tests/test/intl402/6.2.2_b.js View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M test/test262/prune-local-tests.sh View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 5 chunks +91 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Dan Ehrenberg
PTAL
3 years, 10 months ago (2017-02-08 11:43:11 UTC) #6
Dan Ehrenberg
On 2017/02/08 11:43:11, Dan Ehrenberg wrote: > PTAL Poke, WDYT?
3 years, 10 months ago (2017-02-10 08:15:09 UTC) #7
adamk
lgtm Sorry for the delay, was out ski-tripping the last two days.
3 years, 10 months ago (2017-02-10 18:59:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685603003/80001
3 years, 10 months ago (2017-02-10 19:00:04 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:06:02 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/91b79fb789b120c5e11185ef42cd1b88068...

Powered by Google App Engine
This is Rietveld 408576698