Index: tools/clang/blink_gc_plugin/tests/stack_allocated.txt |
diff --git a/tools/clang/blink_gc_plugin/tests/stack_allocated.txt b/tools/clang/blink_gc_plugin/tests/stack_allocated.txt |
index 80980c31cc6084b650a1da04d2794da714e69082..f9c7a1561f81fa3287e8b061aa54317a009eddd9 100644 |
--- a/tools/clang/blink_gc_plugin/tests/stack_allocated.txt |
+++ b/tools/clang/blink_gc_plugin/tests/stack_allocated.txt |
@@ -5,19 +5,22 @@ class PartObject { |
./stack_allocated.h:17:5: note: [blink-gc] Untraced field 'm_obj' declared here: |
Member<HeapObject> m_obj; // Needs tracing. |
^ |
-./stack_allocated.h:26:1: warning: [blink-gc] Class 'HeapObject' contains invalid fields. |
+./stack_allocated.h:24:5: warning: [blink-gc] The stack allocated class 'StackObject' provides an unnecessary trace method: |
+ void Trace(Visitor* visitor) { visitor->Trace(m_obj); } |
+ ^ |
+./stack_allocated.h:30:1: warning: [blink-gc] Class 'HeapObject' contains invalid fields. |
class HeapObject : public GarbageCollected<HeapObject> { |
^ |
-./stack_allocated.h:30:5: note: [blink-gc] Stack-allocated field 'm_part' declared here: |
+./stack_allocated.h:34:5: note: [blink-gc] Stack-allocated field 'm_part' declared here: |
StackObject m_part; // Cannot embed a stack allocated object. |
^ |
-./stack_allocated.h:34:27: warning: [blink-gc] Stack-allocated class 'DerivedHeapObject' derives class 'HeapObject' which is garbage collected. |
+./stack_allocated.h:38:27: warning: [blink-gc] Stack-allocated class 'DerivedHeapObject' derives class 'HeapObject' which is garbage collected. |
class DerivedHeapObject : public HeapObject, public StackObject { |
^ |
-./stack_allocated.h:38:28: warning: [blink-gc] Stack-allocated class 'DerivedHeapObject2' derives class 'HeapObject' which is garbage collected. |
+./stack_allocated.h:42:28: warning: [blink-gc] Stack-allocated class 'DerivedHeapObject2' derives class 'HeapObject' which is garbage collected. |
class DerivedHeapObject2 : public HeapObject { |
^ |
-./stack_allocated.h:39:3: warning: [blink-gc] Garbage collected class 'DerivedHeapObject2' is not permitted to override its new operator. |
+./stack_allocated.h:43:3: warning: [blink-gc] Garbage collected class 'DerivedHeapObject2' is not permitted to override its new operator. |
STACK_ALLOCATED(); |
^ |
./heap/stubs.h:178:5: note: expanded from macro 'STACK_ALLOCATED' |
@@ -29,4 +32,4 @@ class AnonStackObject : public StackObject { |
stack_allocated.cpp:14:5: note: [blink-gc] Raw pointer field 'm_obj' to a GC managed class declared here: |
HeapObject* m_obj; |
^ |
-6 warnings generated. |
+7 warnings generated. |