Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/stack_allocated.txt

Issue 2685583002: blink_gc_plugin: warn of unused trace methods to stack allocated classes. (Closed)
Patch Set: rebased upto r449038 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 In file included from stack_allocated.cpp:5: 1 In file included from stack_allocated.cpp:5:
2 ./stack_allocated.h:14:1: warning: [blink-gc] Class 'PartObject' requires a trac e method. 2 ./stack_allocated.h:14:1: warning: [blink-gc] Class 'PartObject' requires a trac e method.
3 class PartObject { 3 class PartObject {
4 ^ 4 ^
5 ./stack_allocated.h:17:5: note: [blink-gc] Untraced field 'm_obj' declared here: 5 ./stack_allocated.h:17:5: note: [blink-gc] Untraced field 'm_obj' declared here:
6 Member<HeapObject> m_obj; // Needs tracing. 6 Member<HeapObject> m_obj; // Needs tracing.
7 ^ 7 ^
8 ./stack_allocated.h:26:1: warning: [blink-gc] Class 'HeapObject' contains invali d fields. 8 ./stack_allocated.h:24:5: warning: [blink-gc] The stack allocated class 'StackOb ject' provides an unnecessary trace method:
9 void Trace(Visitor* visitor) { visitor->Trace(m_obj); }
10 ^
11 ./stack_allocated.h:30:1: warning: [blink-gc] Class 'HeapObject' contains invali d fields.
9 class HeapObject : public GarbageCollected<HeapObject> { 12 class HeapObject : public GarbageCollected<HeapObject> {
10 ^ 13 ^
11 ./stack_allocated.h:30:5: note: [blink-gc] Stack-allocated field 'm_part' declar ed here: 14 ./stack_allocated.h:34:5: note: [blink-gc] Stack-allocated field 'm_part' declar ed here:
12 StackObject m_part; // Cannot embed a stack allocated object. 15 StackObject m_part; // Cannot embed a stack allocated object.
13 ^ 16 ^
14 ./stack_allocated.h:34:27: warning: [blink-gc] Stack-allocated class 'DerivedHea pObject' derives class 'HeapObject' which is garbage collected. 17 ./stack_allocated.h:38:27: warning: [blink-gc] Stack-allocated class 'DerivedHea pObject' derives class 'HeapObject' which is garbage collected.
15 class DerivedHeapObject : public HeapObject, public StackObject { 18 class DerivedHeapObject : public HeapObject, public StackObject {
16 ^ 19 ^
17 ./stack_allocated.h:38:28: warning: [blink-gc] Stack-allocated class 'DerivedHea pObject2' derives class 'HeapObject' which is garbage collected. 20 ./stack_allocated.h:42:28: warning: [blink-gc] Stack-allocated class 'DerivedHea pObject2' derives class 'HeapObject' which is garbage collected.
18 class DerivedHeapObject2 : public HeapObject { 21 class DerivedHeapObject2 : public HeapObject {
19 ^ 22 ^
20 ./stack_allocated.h:39:3: warning: [blink-gc] Garbage collected class 'DerivedHe apObject2' is not permitted to override its new operator. 23 ./stack_allocated.h:43:3: warning: [blink-gc] Garbage collected class 'DerivedHe apObject2' is not permitted to override its new operator.
21 STACK_ALLOCATED(); 24 STACK_ALLOCATED();
22 ^ 25 ^
23 ./heap/stubs.h:178:5: note: expanded from macro 'STACK_ALLOCATED' 26 ./heap/stubs.h:178:5: note: expanded from macro 'STACK_ALLOCATED'
24 __attribute__((annotate("blink_stack_allocated"))) \ 27 __attribute__((annotate("blink_stack_allocated"))) \
25 ^ 28 ^
26 stack_allocated.cpp:12:1: warning: [blink-gc] Class 'AnonStackObject' contains i nvalid fields. 29 stack_allocated.cpp:12:1: warning: [blink-gc] Class 'AnonStackObject' contains i nvalid fields.
27 class AnonStackObject : public StackObject { 30 class AnonStackObject : public StackObject {
28 ^ 31 ^
29 stack_allocated.cpp:14:5: note: [blink-gc] Raw pointer field 'm_obj' to a GC man aged class declared here: 32 stack_allocated.cpp:14:5: note: [blink-gc] Raw pointer field 'm_obj' to a GC man aged class declared here:
30 HeapObject* m_obj; 33 HeapObject* m_obj;
31 ^ 34 ^
32 6 warnings generated. 35 7 warnings generated.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698