Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2685553004: Convert AwRenderViewHostExt to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert AwRenderViewHostExt to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2685553004 Cr-Commit-Position: refs/heads/master@{#448679} Committed: https://chromium.googlesource.com/chromium/src/+/33480670615a7a5229e9c16cd0ccc641143380a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M android_webview/browser/renderer_host/aw_render_view_host_ext.h View 2 chunks +2 lines, -8 lines 0 comments Download
M android_webview/browser/renderer_host/aw_render_view_host_ext.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jam
3 years, 10 months ago (2017-02-07 17:19:50 UTC) #10
sgurun-gerrit only
lgtm
3 years, 10 months ago (2017-02-07 18:42:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685553004/20001
3 years, 10 months ago (2017-02-07 18:46:16 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 18:52:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33480670615a7a5229e9c16cd0cc...

Powered by Google App Engine
This is Rietveld 408576698