Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2685513002: [For trybots test] [ScreenOrientation] Hide ScreenOrientationProvider inside WebContentsImpl. (Closed)

Created:
3 years, 10 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, mlamouri+watch-screen-orientation_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ScreenOrientation] Hide ScreenOrientationProvider inside WebContentsImpl. BUG=678545 TEST=content_unittests [ScreenOrientation] Merge ScreenOrientation into ScreenOrientationProvider. ScreenOrientation has no actual functionality other than forwarding lock/unlock requests to ScreenOrientationProvider, so this CL merges it into ScreenOrientationProvider and removes it. This CL also removes declarition of content::RenderFrameHostDelegate::GetScreenOrientationProvider() because no codes expect RenderFrameHostDelegate has such a method. BUG=678545 TEST=content_unittests CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation patch from issue 2649823002 at patchset 160001 (http://crrev.com/2649823002#ps160001)

Patch Set 1 #

Patch Set 2 : Fix android bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -449 lines) Patch
M ash/content/screen_orientation_delegate_chromeos.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D content/browser/screen_orientation/screen_orientation.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/screen_orientation/screen_orientation.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_delegate_android.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/screen_orientation/screen_orientation_provider.h View 4 chunks +17 lines, -15 lines 0 comments Download
A + content/browser/screen_orientation/screen_orientation_provider.cc View 7 chunks +31 lines, -19 lines 0 comments Download
A content/browser/screen_orientation/screen_orientation_provider_unittest.cc View 1 chunk +343 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 4 chunks +7 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M content/public/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D content/public/browser/screen_orientation_provider.h View 1 chunk +0 lines, -83 lines 0 comments Download
D content/public/browser/screen_orientation_provider.cc View 1 chunk +0 lines, -210 lines 0 comments Download
M content/public/browser/web_contents.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (9 generated)
leonhsl(Using Gerrit)
3 years, 10 months ago (2017-02-07 08:59:12 UTC) #4

          

Powered by Google App Engine
This is Rietveld 408576698