Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2685513002: [For trybots test] [ScreenOrientation] Hide ScreenOrientationProvider inside WebContentsImpl. (Closed)
Patch Set: Fix android bots Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index bbbe490bb2d7968636487c5a08688b233a327bb7..2ae1f97af68db937d0c4ed6044472212142b1ce6 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -72,7 +72,6 @@ class RenderViewHostDelegateView;
class RenderWidgetHostImpl;
class RenderWidgetHostInputEventRouter;
class SavePackage;
-class ScreenOrientation;
class ScreenOrientationProvider;
class SiteInstance;
class TestWebContents;
@@ -210,6 +209,12 @@ class CONTENT_EXPORT WebContentsImpl
WebContentsView* GetView() const;
+ void OnScreenOrientationChange();
+
+ ScreenOrientationProvider* screen_orientation_provider_for_testing() const {
+ return screen_orientation_provider_.get();
+ }
+
bool should_normally_be_visible() { return should_normally_be_visible_; }
// Indicate if the window has been occluded, and pass this to the views, only
@@ -478,7 +483,6 @@ class CONTENT_EXPORT WebContentsImpl
int browser_plugin_instance_id) override;
device::GeolocationServiceContext* GetGeolocationServiceContext() override;
device::WakeLockServiceContext* GetWakeLockServiceContext() override;
- ScreenOrientationProvider* GetScreenOrientationProvider() override;
void EnterFullscreenMode(const GURL& origin) override;
void ExitFullscreenMode(bool will_cause_resize) override;
bool ShouldRouteMessageEvent(
@@ -1438,7 +1442,7 @@ class CONTENT_EXPORT WebContentsImpl
std::unique_ptr<device::WakeLockServiceContext> wake_lock_service_context_;
- std::unique_ptr<ScreenOrientation> screen_orientation_;
+ std::unique_ptr<ScreenOrientationProvider> screen_orientation_provider_;
std::unique_ptr<ManifestManagerHost> manifest_manager_host_;

Powered by Google App Engine
This is Rietveld 408576698