Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2685353002: Remove outdated WebGL expectation on NVIDIA (Closed)

Created:
3 years, 10 months ago by oetuaho-nv
Modified:
3 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove outdated WebGL expectation on NVIDIA unary-minus-operator-float-bug.html is not failing on NVIDIA anymore since a workaround is in place in ANGLE. BUG=672380 TEST=WebGL conformance CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2685353002 Cr-Commit-Position: refs/heads/master@{#449802} Committed: https://chromium.googlesource.com/chromium/src/+/bfb6d62e98fe74682a7a0c81444b8f837bb48350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
oetuaho-nv
Please review! The ANGLE patch that fixed the bug: https://chromium-review.googlesource.com/c/419016/
3 years, 10 months ago (2017-02-10 15:44:35 UTC) #3
Zhenyao Mo
lgtm Thanks Olli.
3 years, 10 months ago (2017-02-10 17:59:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685353002/1
3 years, 10 months ago (2017-02-10 23:09:36 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 00:15:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bfb6d62e98fe74682a7a0c81444b...

Powered by Google App Engine
This is Rietveld 408576698