Fix content/common typemaps depending on blink_minimal instead of blink_headers.

Fix content/common typemaps depending on blink_minimal instead of blink_headers.

BUG=248653
TBR=wfh@chromium.org

Review-Url: https://codereview.chromium.org/2685343003
Cr-Commit-Position: refs/heads/master@{#449762}
Committed: https://chromium.googlesource.com/chromium/src/+/4b5963fa744a706398f8f06a4cbbf70d7fa3213d

[jam, 2017-02-10 20:41:49]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 20:42:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-10 21:07:08]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-02-10 21:07:12]

Description was changed from

==========
Fix content/common typemaps depending on blink_minimal instead of blink_headers.

This also removes content/common depending on blink_minimal.

BUG=248653
==========

to

==========
Fix content/common typemaps depending on blink_minimal instead of blink_headers.

BUG=248653
==========

[commit-bot: I haz the power, 2017-02-10 21:07:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-10 21:09:36]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org

[jam, 2017-02-10 21:21:26]

It looks like a bug that analyze thought this doesn't need a build; I'll file a
bug for that.

I did verify locally debug & release

[commit-bot: I haz the power, 2017-02-10 21:25:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 21:25:25]

Dry run: This issue passed the CQ dry run.

[scottmg, 2017-02-10 21:27:33]

lgtm

[jam, 2017-02-10 22:14:05]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:14:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-10 22:21:55]

Description was changed from

==========
Fix content/common typemaps depending on blink_minimal instead of blink_headers.

BUG=248653
==========

to

==========
Fix content/common typemaps depending on blink_minimal instead of blink_headers.

BUG=248653
TBR=wfh@chromium.org
==========

[jam, 2017-02-10 22:21:55]

jam@chromium.org changed reviewers:
+ wfh@chromium.org

[jam, 2017-02-10 22:22:06]

TBR wfh for trivial update of typemap

[commit-bot: I haz the power, 2017-02-10 22:25:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486764845294820,
"parent_rev": "ac9032758083fde1bd8f73c73e15ccbbacf21c83", "commit_rev":
"4b5963fa744a706398f8f06a4cbbf70d7fa3213d"}

[commit-bot: I haz the power, 2017-02-10 22:25:49]

Description was changed from

==========
Fix content/common typemaps depending on blink_minimal instead of blink_headers.

BUG=248653
TBR=wfh@chromium.org
==========

to

==========
Fix content/common typemaps depending on blink_minimal instead of blink_headers.

BUG=248653
TBR=wfh@chromium.org

Review-Url: https://codereview.chromium.org/2685343003
Cr-Commit-Position: refs/heads/master@{#449762}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b5963fa744a706398f8f06a4cbb...
==========

[commit-bot: I haz the power, 2017-02-10 22:25:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b5963fa744a706398f8f06a4cbb...

[Will Harris, 2017-02-10 22:26:25]

On 2017/02/10 22:22:06, jam wrote:
> TBR wfh for trivial update of typemap

boo! :( The strongest advocate of never-TBR is TBRing stuff! :)

lgtm

[jam, 2017-02-10 22:27:44]

On 2017/02/10 22:26:25, Will Harris wrote:
> On 2017/02/10 22:22:06, jam wrote:
> > TBR wfh for trivial update of typemap
> 
> boo! :( The strongest advocate of never-TBR is TBRing stuff! :)
> 
> lgtm

sorry, my reasoning was that this is just a build change.

[Will Harris, 2017-02-10 22:29:51]

On 2017/02/10 22:27:44, jam wrote:
> On 2017/02/10 22:26:25, Will Harris wrote:
> > On 2017/02/10 22:22:06, jam wrote:
> > > TBR wfh for trivial update of typemap
> > 
> > boo! :( The strongest advocate of never-TBR is TBRing stuff! :)
> > 
> > lgtm
> 
> sorry, my reasoning was that this is just a build change.

I was going on your post here:

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/2ddB1maCrgg/zr-Ku...

but the guidelines seem to be here:

https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md

perhaps we need more examples here of what is appropriate and what is
inappropriate?

[jam, 2017-02-10 22:33:28]

On 2017/02/10 22:29:51, Will Harris wrote:
> On 2017/02/10 22:27:44, jam wrote:
> > On 2017/02/10 22:26:25, Will Harris wrote:
> > > On 2017/02/10 22:22:06, jam wrote:
> > > > TBR wfh for trivial update of typemap
> > > 
> > > boo! :( The strongest advocate of never-TBR is TBRing stuff! :)
> > > 
> > > lgtm
> > 
> > sorry, my reasoning was that this is just a build change.
> 
> I was going on your post here:
> 
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/2ddB1maCrgg/zr-Ku...
> 
> but the guidelines seem to be here:
> 
> https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md
> 
> perhaps we need more examples here of what is appropriate and what is
> inappropriate?

ok you're right i was being impatient; thanks for pointing it out.