chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

index 48395cb324895e689211f529b42b45ba44b00d6c..4ff581cf054632996e98885747a5d86470503f65 100644

--- a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

@@ -502,7 +502,7 @@ TEST_F(BackFwdMenuModelTest, EscapeLabel) {

TEST_F(BackFwdMenuModelTest, FaviconLoadTest) {

ASSERT_TRUE(profile()->CreateHistoryService(true, false));

profile()->CreateFaviconService();

- Browser::CreateParams native_params(profile());

+ Browser::CreateParams native_params(profile(), true);

std::unique_ptr<Browser> browser(

chrome::CreateBrowserWithTestWindowForParams(&native_params));

FaviconDelegate favicon_delegate;