chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

diff --git a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

index 7c0e3f87f7e2bb15dfb29cf5102c43fc35419ecb..9ea5488dd5b01cee97bfa08770fc3e6c5a4c7e50 100644

--- a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

+++ b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

@@ -657,7 +657,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarIncognitoTest, IncognitoMode) {

test_data_dir_.AppendASCII("api_test/browser_action_with_icon"));

ASSERT_TRUE(extension);

Browser* second_browser =

- new Browser(Browser::CreateParams(profile()->GetOriginalProfile()));

+ new Browser(Browser::CreateParams(profile()->GetOriginalProfile(), true));

base::RunLoop().RunUntilIdle();

EXPECT_FALSE(second_browser->profile()->IsOffTheRecord());