Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
index d3f1d623800906893153ca47b6fe3e60300bf800..7a2e089279b4501710be7bdc0e35569f03d1d4a7 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -447,8 +447,15 @@ Browser* StartupBrowserCreatorImpl::OpenTabsInBrowser(Browser* browser,
if (!profile_ && browser)
profile_ = browser->profile();
- if (!browser || !browser->is_type_tabbed())
- browser = new Browser(Browser::CreateParams(profile_));
+ if (!browser || !browser->is_type_tabbed()) {
+ // Startup browsers are not counted as being created by a user_gesture
+ // because of historical accident, even though the startup browser was
+ // created in response to the user clicking on chrome. There was an
+ // incomplete check on whether a user gesture created a window which looked
+ // at the state of the MessageLoop.
+ Browser::CreateParams params = Browser::CreateParams(profile_, false);
+ browser = new Browser(params);
+ }
bool first_tab = true;
ProtocolHandlerRegistry* registry = profile_ ?

Powered by Google App Engine
This is Rietveld 408576698