Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7748)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index 1cdbcafb9e8ba4fe4094801680eb371b0707b4a9..073cf4f89c77456e05dfeafc7538d9e1afb1b405 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -229,7 +229,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenURLsPopup) {
BrowserList::AddObserver(&observer);
Browser* popup = new Browser(
- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(), true));
ASSERT_TRUE(popup->is_type_popup());
ASSERT_EQ(popup, observer.added_browser_);
@@ -526,14 +526,14 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, PRE_UpdateWithTwoProfiles) {
// Open some urls with the browsers, and close them.
Browser* browser1 =
- new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile1));
+ new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile1, true));
chrome::NewTab(browser1);
ui_test_utils::NavigateToURL(browser1,
embedded_test_server()->GetURL("/empty.html"));
CloseBrowserSynchronously(browser1);
- Browser* browser2 = new Browser(
- Browser::CreateParams(Browser::TYPE_TABBED, profile2));
+ Browser* browser2 =
+ new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile2, true));
chrome::NewTab(browser2);
ui_test_utils::NavigateToURL(browser2,
embedded_test_server()->GetURL("/form.html"));
@@ -667,7 +667,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest,
// Open a page with profile_last.
Browser* browser_last = new Browser(
- Browser::CreateParams(Browser::TYPE_TABBED, profile_last));
+ Browser::CreateParams(Browser::TYPE_TABBED, profile_last, true));
chrome::NewTab(browser_last);
ui_test_utils::NavigateToURL(browser_last,
embedded_test_server()->GetURL("/empty.html"));

Powered by Google App Engine
This is Rietveld 408576698