Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm
index 98dc739d7fb3723d5292054305629255f27b41e0..05cd5b296bcfa6fa80b74900fab04a1fac21c8ae 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm
@@ -204,7 +204,7 @@ TEST_F(ProfileMenuControllerTest, SetActiveAndRemove) {
ASSERT_EQ(7, [menu numberOfItems]);
// Create a browser and "show" it.
- Browser::CreateParams profile2_params(profile2);
+ Browser::CreateParams profile2_params(profile2, true);
std::unique_ptr<Browser> p2_browser(
chrome::CreateBrowserWithTestWindowForParams(&profile2_params));
BrowserList::SetLastActive(p2_browser.get());
@@ -215,7 +215,7 @@ TEST_F(ProfileMenuControllerTest, SetActiveAndRemove) {
VerifyProfileNamedIsActive(@"Profile 2", __LINE__);
// Open a new browser and make sure it takes effect.
- Browser::CreateParams profile3_params(profile3);
+ Browser::CreateParams profile3_params(profile3, true);
std::unique_ptr<Browser> p3_browser(
chrome::CreateBrowserWithTestWindowForParams(&profile3_params));
BrowserList::SetLastActive(p3_browser.get());
@@ -282,7 +282,7 @@ TEST_F(ProfileMenuControllerTest, SupervisedProfile) {
EXPECT_TRUE([controller() validateMenuItem:item]);
// Open a new browser for the supervised user and switch to it.
- Browser::CreateParams supervised_profile_params(supervised_profile);
+ Browser::CreateParams supervised_profile_params(supervised_profile, true);
std::unique_ptr<Browser> supervised_browser(
chrome::CreateBrowserWithTestWindowForParams(&supervised_profile_params));
BrowserList::SetLastActive(supervised_browser.get());

Powered by Google App Engine
This is Rietveld 408576698