chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_factory_cocoa.mm ('k') | chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm

index e5170950318cdfb3002b51da9223081f1f732874..18fe91c9eb00f65f006369cef4349bee84095d93 100644

--- a/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm

@@ -49,8 +49,8 @@ class AvatarIconControllerTest : public CocoaProfileTest {

};

TEST_F(AvatarIconControllerTest, ShowingAvatarIconInIncognito) {

- Browser* browser =

- new Browser(Browser::CreateParams(profile()->GetOffTheRecordProfile()));

+ Browser* browser = new Browser(

+ Browser::CreateParams(profile()->GetOffTheRecordProfile(), true));

BrowserWindowCocoa* window =

static_cast<BrowserWindowCocoa*>(browser->window());

AvatarBaseController* icon_controller =