Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/profiles/profile_manager_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_manager_unittest.cc
diff --git a/chrome/browser/profiles/profile_manager_unittest.cc b/chrome/browser/profiles/profile_manager_unittest.cc
index 6a66ac55f2c3c9a757d50e71e551db91e13a9ff6..f5c4ef14aea5ab227518fdaf8f08253c9c763778 100644
--- a/chrome/browser/profiles/profile_manager_unittest.cc
+++ b/chrome/browser/profiles/profile_manager_unittest.cc
@@ -713,7 +713,7 @@ TEST_F(ProfileManagerTest, LastOpenedProfiles) {
ASSERT_EQ(0U, last_opened_profiles.size());
// Create a browser for profile1.
- Browser::CreateParams profile1_params(profile1);
+ Browser::CreateParams profile1_params(profile1, true);
std::unique_ptr<Browser> browser1a(
chrome::CreateBrowserWithTestWindowForParams(&profile1_params));
@@ -722,7 +722,7 @@ TEST_F(ProfileManagerTest, LastOpenedProfiles) {
EXPECT_EQ(profile1, last_opened_profiles[0]);
// And for profile2.
- Browser::CreateParams profile2_params(profile2);
+ Browser::CreateParams profile2_params(profile2, true);
std::unique_ptr<Browser> browser2(
chrome::CreateBrowserWithTestWindowForParams(&profile2_params));
@@ -775,12 +775,12 @@ TEST_F(ProfileManagerTest, LastOpenedProfilesAtShutdown) {
ASSERT_TRUE(profile2);
// Create a browser for profile1.
- Browser::CreateParams profile1_params(profile1);
+ Browser::CreateParams profile1_params(profile1, true);
std::unique_ptr<Browser> browser1(
chrome::CreateBrowserWithTestWindowForParams(&profile1_params));
// And for profile2.
- Browser::CreateParams profile2_params(profile2);
+ Browser::CreateParams profile2_params(profile2, true);
std::unique_ptr<Browser> browser2(
chrome::CreateBrowserWithTestWindowForParams(&profile2_params));
@@ -825,7 +825,7 @@ TEST_F(ProfileManagerTest, LastOpenedProfilesDoesNotContainIncognito) {
ASSERT_EQ(0U, last_opened_profiles.size());
// Create a browser for profile1.
- Browser::CreateParams profile1_params(profile1);
+ Browser::CreateParams profile1_params(profile1, true);
std::unique_ptr<Browser> browser1(
chrome::CreateBrowserWithTestWindowForParams(&profile1_params));
@@ -834,7 +834,8 @@ TEST_F(ProfileManagerTest, LastOpenedProfilesDoesNotContainIncognito) {
EXPECT_EQ(profile1, last_opened_profiles[0]);
// And for profile2.
- Browser::CreateParams profile2_params(profile1->GetOffTheRecordProfile());
+ Browser::CreateParams profile2_params(profile1->GetOffTheRecordProfile(),
+ true);
std::unique_ptr<Browser> browser2a(
chrome::CreateBrowserWithTestWindowForParams(&profile2_params));
@@ -884,7 +885,7 @@ TEST_F(ProfileManagerTest, EphemeralProfilesDontEndUpAsLastProfile) {
EXPECT_NE(profile, last_used_profile);
// Create a browser for the profile.
- Browser::CreateParams profile_params(profile);
+ Browser::CreateParams profile_params(profile, true);
std::unique_ptr<Browser> browser(
chrome::CreateBrowserWithTestWindowForParams(&profile_params));
last_used_profile = profile_manager->GetLastUsedProfile();
@@ -926,16 +927,16 @@ TEST_F(ProfileManagerTest, EphemeralProfilesDontEndUpAsLastOpenedAtShutdown) {
ASSERT_TRUE(ephemeral_profile2);
// Create a browser for profile1.
- Browser::CreateParams profile1_params(normal_profile);
+ Browser::CreateParams profile1_params(normal_profile, true);
std::unique_ptr<Browser> browser1(
chrome::CreateBrowserWithTestWindowForParams(&profile1_params));
// Create browsers for the ephemeral profile.
- Browser::CreateParams profile2_params(ephemeral_profile1);
+ Browser::CreateParams profile2_params(ephemeral_profile1, true);
std::unique_ptr<Browser> browser2(
chrome::CreateBrowserWithTestWindowForParams(&profile2_params));
- Browser::CreateParams profile3_params(ephemeral_profile2);
+ Browser::CreateParams profile3_params(ephemeral_profile2, true);
std::unique_ptr<Browser> browser3(
chrome::CreateBrowserWithTestWindowForParams(&profile3_params));
« no previous file with comments | « chrome/browser/profiles/avatar_menu_actions_desktop.cc ('k') | chrome/browser/safe_browsing/srt_fetcher_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698