Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: chrome/browser/profiles/avatar_menu_actions_desktop.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: Rebase to ToT Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/avatar_menu_actions_desktop.cc
diff --git a/chrome/browser/profiles/avatar_menu_actions_desktop.cc b/chrome/browser/profiles/avatar_menu_actions_desktop.cc
index 1d22aa301810e9ba7836382bfb0ca3eea77ec1df..6db41b61c0aacfff73c3c41c43b1b5e78cb49e1c 100644
--- a/chrome/browser/profiles/avatar_menu_actions_desktop.cc
+++ b/chrome/browser/profiles/avatar_menu_actions_desktop.cc
@@ -27,7 +27,8 @@ void AvatarMenuActionsDesktop::AddNewProfile(ProfileMetrics::ProfileAdd type) {
Browser* settings_browser = browser_;
if (!settings_browser) {
- const Browser::CreateParams params(ProfileManager::GetLastUsedProfile());
+ const Browser::CreateParams params(ProfileManager::GetLastUsedProfile(),
+ true);
settings_browser = new Browser(params);
}
chrome::ShowSettingsSubPage(settings_browser, chrome::kCreateProfileSubPage);
@@ -37,7 +38,7 @@ void AvatarMenuActionsDesktop::AddNewProfile(ProfileMetrics::ProfileAdd type) {
void AvatarMenuActionsDesktop::EditProfile(Profile* profile) {
Browser* settings_browser = browser_;
if (!settings_browser) {
- settings_browser = new Browser(Browser::CreateParams(profile));
+ settings_browser = new Browser(Browser::CreateParams(profile, true));
}
// TODO(davidben): The manageProfile page only allows editting the profile
// associated with the browser it is opened in. AvatarMenuActionsDesktop
« no previous file with comments | « chrome/browser/prefetch/prefetch_browsertest.cc ('k') | chrome/browser/profiles/profile_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698