chrome/test/base/browser_with_test_window_test.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/browser_with_test_window_test.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/browser_with_test_window_test.cc

diff --git a/chrome/test/base/browser_with_test_window_test.cc b/chrome/test/base/browser_with_test_window_test.cc

index cbc2e3e2d546589b35f35be513b2a78b266f568e..bb950d31f22764983d32cd1212fe599f30ea88fb 100644

--- a/chrome/test/base/browser_with_test_window_test.cc

+++ b/chrome/test/base/browser_with_test_window_test.cc

@@ -200,10 +200,10 @@ Browser* BrowserWithTestWindowTest::CreateBrowser(

Browser::Type browser_type,

bool hosted_app,

BrowserWindow* browser_window) {

- Browser::CreateParams params(profile);

+ Browser::CreateParams params(profile, true);

if (hosted_app) {

params = Browser::CreateParams::CreateForApp(

- "Test", true /* trusted_source */, gfx::Rect(), profile);

+ "Test", true /* trusted_source */, gfx::Rect(), profile, true);

} else {

params.type = browser_type;

}