Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: chrome/browser/ui/browser.h

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index dce38b644a549d05d094ef33e73bc8a20a5bad41..dc9f8b5da1019da99c3e039e5986f2381b0ea088 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -156,14 +156,15 @@ class Browser : public TabStripModelObserver,
};
struct CreateParams {
- explicit CreateParams(Profile* profile);
- CreateParams(Type type, Profile* profile);
+ explicit CreateParams(Profile* profile, bool user_gesture);
+ CreateParams(Type type, Profile* profile, bool user_gesture);
CreateParams(const CreateParams& other);
static CreateParams CreateForApp(const std::string& app_name,
bool trusted_source,
const gfx::Rect& window_bounds,
- Profile* profile);
+ Profile* profile,
+ bool user_gesture);
static CreateParams CreateForDevTools(Profile* profile);
@@ -186,6 +187,12 @@ class Browser : public TabStripModelObserver,
bool is_session_restore;
+ // Whether this browser was created by a user generated event. We track
sky 2017/02/21 21:42:07 When I think of generated I think of https://chrom
Elliot Glaysher 2017/02/21 21:53:50 Reverted phrasing to what I originally had.
+ // this specifically for the multi-user case in chromeos where we can place
+ // windows generated by user gestures differently from ones programmatically
+ // created.
+ bool user_gesture;
+
// Supply a custom BrowserWindow implementation, to be used instead of the
// default. Intended for testing.
BrowserWindow* window;

Powered by Google App Engine
This is Rietveld 408576698