chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.h ('K') | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

index 3f0edc3d7128169fe4240bbb97ec47eaad1642df..1e506e444aab8ab6f4751dbbe071a4a2b55a8e58 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

@@ -2016,7 +2016,7 @@ IN_PROC_BROWSER_TEST_P(DetachToBrowserInSeparateDisplayTabDragControllerTest,

->GetDisplayNearestWindow(second_root)

.work_area();

work_area.Inset(20, 20, 20, 60);

- Browser::CreateParams params(browser()->profile());

+ Browser::CreateParams params(browser()->profile(), true);

params.initial_show_state = ui::SHOW_STATE_NORMAL;

params.initial_bounds = work_area;

Browser* browser2 = new Browser(params);