Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4348)

Unified Diff: chrome/browser/ui/views/frame/browser_view_browsertest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view_browsertest.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_browsertest.cc b/chrome/browser/ui/views/frame/browser_view_browsertest.cc
index 9c638626a51bea9c22544197e8d3256137cb2b71..1136ae7e7658a807e89ac21104c03409278a0c93 100644
--- a/chrome/browser/ui/views/frame/browser_view_browsertest.cc
+++ b/chrome/browser/ui/views/frame/browser_view_browsertest.cc
@@ -85,7 +85,8 @@ class TestWebContentsObserver : public content::WebContentsObserver {
// Additionally when one of the tabs is destroyed NotifyNavigationStateChanged()
// is invoked on the other.
IN_PROC_BROWSER_TEST_F(BrowserViewTest, CloseWithTabs) {
- Browser* browser2 = new Browser(Browser::CreateParams(browser()->profile()));
+ Browser* browser2 =
+ new Browser(Browser::CreateParams(browser()->profile(), true));
chrome::AddTabAt(browser2, GURL(), -1, true);
chrome::AddTabAt(browser2, GURL(), -1, true);
TestWebContentsObserver observer(
@@ -97,7 +98,8 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, CloseWithTabs) {
// Same as CloseWithTabs, but activates the first tab, which is the first tab
// BrowserView will destroy.
IN_PROC_BROWSER_TEST_F(BrowserViewTest, CloseWithTabsStartWithActive) {
- Browser* browser2 = new Browser(Browser::CreateParams(browser()->profile()));
+ Browser* browser2 =
+ new Browser(Browser::CreateParams(browser()->profile(), true));
chrome::AddTabAt(browser2, GURL(), -1, true);
chrome::AddTabAt(browser2, GURL(), -1, true);
browser2->tab_strip_model()->ActivateTabAt(0, true);

Powered by Google App Engine
This is Rietveld 408576698