chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.h ('K') | « chrome/browser/ui/scoped_tabbed_browser_displayer.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

diff --git a/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc b/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

index 49f37563b2462fca5b5cc907e4594373f7239165..cb8f25841bc6bb33d0eac621ecf8390677c0e5f5 100644

--- a/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

+++ b/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

@@ -57,7 +57,7 @@ TEST_F(SessionCrashedInfoBarDelegateUnitTest, DetachingTabWithCrashedInfoBar) {

browser()->profile()))));

// Create a browser which we can close during the test.

- Browser::CreateParams params(browser()->profile());

+ Browser::CreateParams params(browser()->profile(), true);

std::unique_ptr<Browser> first_browser(

chrome::CreateBrowserWithTestWindowForParams(&params));

AddTab(first_browser.get(), GURL(chrome::kChromeUINewTabURL));