Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6370)

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index 22a62f7fa9311ca61ae57882003d026b6d767e54..c5029caa42d0fb30d0826986e7105be487129b48 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -231,7 +231,7 @@ TEST_F(BrowserCommandControllerTest, AvatarMenuAlwaysDisabledInIncognitoMode) {
// Create a new browser based on the off the record profile.
Browser::CreateParams profile_params(
- original_profile->GetOffTheRecordProfile());
+ original_profile->GetOffTheRecordProfile(), true);
std::unique_ptr<Browser> otr_browser(
chrome::CreateBrowserWithTestWindowForParams(&profile_params));
@@ -423,7 +423,8 @@ TEST_F(BrowserCommandControllerTest, IncognitoModeOnSigninAllowedPrefChange) {
EXPECT_EQ(profile2->GetOriginalProfile(), profile1.get());
// Create a new browser based on the off the record profile.
- Browser::CreateParams profile_params(profile1->GetOffTheRecordProfile());
+ Browser::CreateParams profile_params(profile1->GetOffTheRecordProfile(),
+ true);
std::unique_ptr<Browser> browser2(
chrome::CreateBrowserWithTestWindowForParams(&profile_params));

Powered by Google App Engine
This is Rietveld 408576698