Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5169)

Unified Diff: chrome/browser/safe_browsing/srt_fetcher_win.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: rebase to tot Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/srt_fetcher_win.cc
diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.cc b/chrome/browser/safe_browsing/srt_fetcher_win.cc
index 6a3ca19d824da3bfd1120c3bc0545762a23a3160..7cc71fa5699cdec8ac9d8d6120d0e2d05e170a40 100644
--- a/chrome/browser/safe_browsing/srt_fetcher_win.cc
+++ b/chrome/browser/safe_browsing/srt_fetcher_win.cc
@@ -527,8 +527,11 @@ void DisplaySRTPrompt(const base::FilePath& download_path) {
// the toolbar's wrench menu. Create one if none exist already.
if (browser->type() != Browser::TYPE_TABBED) {
browser = chrome::FindTabbedBrowser(profile, false);
- if (!browser)
- browser = new Browser(Browser::CreateParams(profile));
+ if (!browser) {
+ Browser::CreateParams params = Browser::CreateParams(profile);
+ params.user_gesture = false;
Mr4D (OOO till 08-26) 2017/02/13 23:57:39 A default of true is odd. But ok
joenotcharles 2017/02/14 00:09:16 I feel like most people who call CreateParms won't
joenotcharles 2017/02/14 00:10:39 (That said, I'm skeptical that plumbing this throu
+ browser = new Browser(params);
+ }
}
GlobalErrorService* global_error_service =
GlobalErrorServiceFactory::GetForProfile(profile);

Powered by Google App Engine
This is Rietveld 408576698