ash: fix regression where ctrl+n put new window on wrong desktop

chrome/browser/safe_browsing/srt_fetcher_win.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/srt_fetcher_win.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 509 matching lines @@
   if (!browser)
     return;
 
   Profile* profile = browser->profile();
   DCHECK(profile);
 
   // Make sure we have a tabbed browser since we need to anchor the bubble to
   // the toolbar's wrench menu. Create one if none exist already.
   if (browser->type() != Browser::TYPE_TABBED) {
     browser = chrome::FindTabbedBrowser(profile, false);
-    if (!browser)
-      browser = new Browser(Browser::CreateParams(profile));
+    if (!browser) {
+      Browser::CreateParams params = Browser::CreateParams(profile);
+      params.user_gesture = false;

[Mr4D (OOO till 08-26), 2017/02/13 23:57:39]

A default of true is odd. But ok

[joenotcharles, 2017/02/14 00:09:16]

I feel like most people who call CreateParms won't know that the user_gesture
field exists and won't bother to set it. If the default isn't always the right
thing to do for callers who don't know to set it (and I don't think it is) then
it should be always be passed as a parameter to CreateParams so that every
caller has to think about what to set it to.

[joenotcharles, 2017/02/14 00:10:39]

(That said, I'm skeptical that plumbing this through everywhere is a good idea,
but I don't have a better suggestion.)

+      browser = new Browser(params);
+    }
   }
   GlobalErrorService* global_error_service =
       GlobalErrorServiceFactory::GetForProfile(profile);
   SRTGlobalError* global_error =
       new SRTGlobalError(global_error_service, download_path);
 
   // Ownership of |global_error| is passed to the service. The error removes
   // itself from the service and self-destructs when done.
   global_error_service->AddGlobalError(base::WrapUnique(global_error));
 
@@ skipping 538 matching lines @@
   return srt_cleaner_key.Open(HKEY_CURRENT_USER, cleaner_key_path.c_str(),
                               KEY_QUERY_VALUE) == ERROR_SUCCESS &&
          srt_cleaner_key.GetValueCount() > 0;
 }
 
 void SetSwReporterTestingDelegate(SwReporterTestingDelegate* delegate) {
   g_testing_delegate_ = delegate;
 }
 
 }  // namespace safe_browsing