Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2685303003: PPC/s390: [wasm] Do not use setjmp/longjmp in cctests. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [wasm] Do not use setjmp/longjmp in cctests. Port 79570f87a1b467846a51c60186e4707f68a4d3d0 Original Commit Message: The use of setjmp/longjmp makes the cctests in test-run-wasm and test-run-wasm-64 flaky on Windows, and I think that it is better not to use it. With this CL I replace it as follows: Similar to the setjmp/longjmp implementation we still call a C function when a trap happens. However, instead of calling longjmp in this C function we just set a flag which indicates that a trap happened and then return. After we return from the C function we leave the frame of the current wasm function and return with a RET instruction. At the end of a test the wasm test runner checks the flag to see if a trap happened. Please take a special look at the LeaveFrame function on arm64. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2685303003 Cr-Commit-Position: refs/heads/master@{#43110} Committed: https://chromium.googlesource.com/v8/v8/+/13042c9a19b58909905da23129ea5445f8e050db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-10 13:52:28 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-10 15:07:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685303003/1
3 years, 10 months ago (2017-02-10 15:09:56 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 15:36:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/13042c9a19b58909905da23129ea5445f8e...

Powered by Google App Engine
This is Rietveld 408576698