Add UpdateNotificationSize to MessageCenterController.

Add UpdateNotificationSize to MessageCenterController.

ArcCustomNotificationView can have its underlying surface change size
without a notification update happening afterwards. So, add a method to
force re-layout of it.

BUG=690813
Review-Url: https://codereview.chromium.org/2685283002
Cr-Commit-Position: refs/heads/master@{#450270}
Committed: https://chromium.googlesource.com/chromium/src/+/c7b92666d510df1c3f33db9ec6cc9b17b8d5360a

[Eliot Courtney, 2017-02-13 01:34:28]

The CQ bit was checked by edcourtney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 01:34:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eliot Courtney, 2017-02-13 01:37:07]

edcourtney@chromium.org changed reviewers:
+ xiyuan@chromium.org, yoshiki@chromium.org

[xiyuan, 2017-02-13 21:54:07]

lgtm

https://codereview.chromium.org/2685283002/diff/40001/ui/message_center/views...
File ui/message_center/views/message_center_controller.h (right):

https://codereview.chromium.org/2685283002/diff/40001/ui/message_center/views...
ui/message_center/views/message_center_controller.h:37: virtual void
ShouldUpdateNotification(const std::string& notification_id) = 0;
nit: ShouldUpdateNotification -> UpdateNotification

Drop prefix "Should" to make it more clear that it performs some action.

[Eliot Courtney, 2017-02-14 02:25:53]

Yoshiki, could you review for owners please?

https://codereview.chromium.org/2685283002/diff/40001/ui/message_center/views...
File ui/message_center/views/message_center_controller.h (right):

https://codereview.chromium.org/2685283002/diff/40001/ui/message_center/views...
ui/message_center/views/message_center_controller.h:37: virtual void
ShouldUpdateNotification(const std::string& notification_id) = 0;
On 2017/02/13 21:54:07, xiyuan wrote:
> nit: ShouldUpdateNotification -> UpdateNotification
> 
> Drop prefix "Should" to make it more clear that it performs some action.

Done.

[yoshiki, 2017-02-14 02:41:40]

https://codereview.chromium.org/2685283002/diff/60001/ui/message_center/views...
File ui/message_center/views/message_center_controller.h (right):

https://codereview.chromium.org/2685283002/diff/60001/ui/message_center/views...
ui/message_center/views/message_center_controller.h:37: virtual void
UpdateNotification(const std::string& notification_id) = 0;
nit: I think "UpdateNotificationSize" may be better since in ToastContentsView
this methold updates only its size.

https://codereview.chromium.org/2685283002/diff/60001/ui/message_center/views...
File ui/message_center/views/message_popup_collection.cc (right):

https://codereview.chromium.org/2685283002/diff/60001/ui/message_center/views...
ui/message_center/views/message_popup_collection.cc:130:
OnNotificationUpdated(notification_id);
Out of curious, is it called actually? IIRC, MessageCenterController methods of
MessagePopupCollection are called from only ToastContetsView but you don't call
this method from ToastContetsView.

[Eliot Courtney, 2017-02-14 03:32:15]

https://codereview.chromium.org/2685283002/diff/60001/ui/message_center/views...
File ui/message_center/views/message_center_controller.h (right):

https://codereview.chromium.org/2685283002/diff/60001/ui/message_center/views...
ui/message_center/views/message_center_controller.h:37: virtual void
UpdateNotification(const std::string& notification_id) = 0;
On 2017/02/14 02:41:39, yoshiki wrote:
> nit: I think "UpdateNotificationSize" may be better since in ToastContentsView
> this methold updates only its size.

Done.

https://codereview.chromium.org/2685283002/diff/60001/ui/message_center/views...
File ui/message_center/views/message_popup_collection.cc (right):

https://codereview.chromium.org/2685283002/diff/60001/ui/message_center/views...
ui/message_center/views/message_popup_collection.cc:130:
OnNotificationUpdated(notification_id);
On 2017/02/14 02:41:39, yoshiki wrote:
> Out of curious, is it called actually? IIRC, MessageCenterController methods
of
> MessagePopupCollection are called from only ToastContetsView but you don't
call
> this method from ToastContetsView.

Good catch~! I've updated the ToastContentsView method to forward the callback
to here like the other methods in ToastContentsView. Toasts still seem to
properly resize.

[Eliot Courtney, 2017-02-14 03:32:25]

Description was changed from

==========
Add ShouldUpdateNotification to MessageCenterController.

ArcCustomNotificationView can have its underlying surface change size
without a notification update happening afterwards. So, add a method to
force re-layout of it.

BUG=690813
==========

to

==========
Add UpdateNotificationSize to MessageCenterController.

ArcCustomNotificationView can have its underlying surface change size
without a notification update happening afterwards. So, add a method to
force re-layout of it.

BUG=690813
==========

[yoshiki, 2017-02-14 04:25:36]

lgtm

[Eliot Courtney, 2017-02-14 04:30:47]

The CQ bit was checked by edcourtney@chromium.org

[Eliot Courtney, 2017-02-14 04:30:47]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2685283002/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2017-02-14 04:31:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 05:36:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487046647328450,
"parent_rev": "893e5368f341ca7e3b047f9ec76c62b083d68b73", "commit_rev":
"c7b92666d510df1c3f33db9ec6cc9b17b8d5360a"}

[commit-bot: I haz the power, 2017-02-14 05:37:34]

Description was changed from

==========
Add UpdateNotificationSize to MessageCenterController.

ArcCustomNotificationView can have its underlying surface change size
without a notification update happening afterwards. So, add a method to
force re-layout of it.

BUG=690813
==========

to

==========
Add UpdateNotificationSize to MessageCenterController.

ArcCustomNotificationView can have its underlying surface change size
without a notification update happening afterwards. So, add a method to
force re-layout of it.

BUG=690813

Review-Url: https://codereview.chromium.org/2685283002
Cr-Commit-Position: refs/heads/master@{#450270}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7b92666d510df1c3f33db9ec6cc...
==========

[commit-bot: I haz the power, 2017-02-14 05:37:35]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c7b92666d510df1c3f33db9ec6cc...