Issue 268523002: Merge 171165 "Add CharacterData.deleteData()/replaceData() overf..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268523002: Merge 171165 "Add CharacterData.deleteData()/replaceData() overf..." (Closed)

Created:
6 years, 7 months ago by aarya

Modified:
6 years, 7 months ago

Reviewers:
sof

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1847/

Visibility:
Public.

Merge 171165 "Add CharacterData.deleteData()/replaceData() overf..." > Add CharacterData.deleteData()/replaceData() overflow handling. > > If the offset and count exceed the underlying length, the spec tells us > > http://dom.spec.whatwg.org/#concept-cd-replace (step 3) > > to use a count that is equal to length minus the offset. Perform that > check in an overflow-sensitive manner. > > (Change based on https://codereview.chromium.org/188693007/ ) > > R= > BUG=349898 > > Review URL: https://codereview.chromium.org/229793004 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173028

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -19 lines)			Patch
A +	LayoutTests/fast/dom/Range/deleteData-replaceData-count-overflow.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/dom/Range/deleteData-replaceData-count-overflow-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/dom/CharacterData.cpp	View	2 chunks	+23 lines, -20 lines	0 comments	Download
M	Source/core/editing/FrameSelection.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r173028.