Source/core/editing/FrameSelection.cpp - Issue 268523002: Merge 171165 "Add CharacterData.deleteData()/replaceData() overf..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 268523002: Merge 171165 "Add CharacterData.deleteData()/replaceData() overf..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1847/

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FrameSelection.cpp

===================================================================

--- Source/core/editing/FrameSelection.cpp (revision 173027)

+++ Source/core/editing/FrameSelection.cpp (working copy)

@@ -379,7 +379,7 @@

if (positionOffset > offset + oldLength)

positionOffset = positionOffset - oldLength + newLength;

- ASSERT(positionOffset <= node->length());

+ ASSERT_WITH_SECURITY_IMPLICATION(positionOffset <= node->length());

// CharacterNode in VisibleSelection must be Text node, because Comment

// and ProcessingInstruction node aren't visible.

return Position(toText(node), positionOffset);

« no previous file with comments | « Source/core/dom/CharacterData.cpp ('k') | no next file » | no next file with comments »