Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(354)

Issue 2685203002: Disable dev mode bubble and some infobars during remote debugging. (Closed)

Created:
3 years ago by samuong
Modified:
3 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Tom Sepez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable dev mode bubble and some infobars during remote debugging. BUG=chromedriver:1625

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/ui/extensions/extension_message_bubble_factory.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 30 (11 generated)
samuong
Pavel, here's an alternative CL that implements the method that you suggested in https://codereview.chromium.org/2564973002 I ...
3 years ago (2017-02-09 22:28:08 UTC) #2
pfeldman
lgtm
3 years ago (2017-02-09 22:53:46 UTC) #3
pfeldman
+sky@ for OWNERS: this disables some of the UI bubbles and infobars while remote debugging.
3 years ago (2017-02-09 22:55:21 UTC) #5
Devlin
Hmm... I'm not sure I follow. How does this help prevent the abuse case?
3 years ago (2017-02-09 23:42:03 UTC) #6
samuong
The argument is that --remote-debugging-port leaves a browser wide open anyway. If a user has ...
3 years ago (2017-02-10 17:31:16 UTC) #7
pfeldman
+ tsepez@ for the security aspect. context: we block various bubbles when chrome is running ...
3 years ago (2017-02-10 19:29:54 UTC) #10
Devlin
On 2017/02/10 19:29:54, pfeldman wrote: > + tsepez@ for the security aspect. > > context: ...
3 years ago (2017-02-10 19:37:56 UTC) #11
pfeldman
>> Wait - so if I want to disable all chrome's security bubbles and infobars, ...
3 years ago (2017-02-10 19:50:06 UTC) #12
Tom Sepez
Adding some of the security UI folks instead. Thanks.
3 years ago (2017-02-10 21:51:36 UTC) #15
lgarron
On 2017/02/10 at 21:51:36, tsepez wrote: > Adding some of the security UI folks instead. ...
3 years ago (2017-02-10 21:54:45 UTC) #16
pfeldman
> We have infobars for a bunch of insecure testing flags, and "this flag is ...
3 years ago (2017-02-10 22:05:33 UTC) #17
pfeldman
Talked to Peter. We seem to all realize that there are two aspects of the ...
3 years ago (2017-02-10 22:47:50 UTC) #19
Peter Kasting
LGTM https://codereview.chromium.org/2685203002/diff/1/chrome/browser/ui/startup/startup_browser_creator_impl.cc File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right): https://codereview.chromium.org/2685203002/diff/1/chrome/browser/ui/startup/startup_browser_creator_impl.cc#newcode815 chrome/browser/ui/startup/startup_browser_creator_impl.cc:815: !command_line_.HasSwitch(switches::kRemoteDebuggingPort)) { Maybe this should comment about why ...
3 years ago (2017-02-11 03:57:09 UTC) #20
samuong
https://codereview.chromium.org/2685203002/diff/1/chrome/browser/ui/startup/startup_browser_creator_impl.cc File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right): https://codereview.chromium.org/2685203002/diff/1/chrome/browser/ui/startup/startup_browser_creator_impl.cc#newcode815 chrome/browser/ui/startup/startup_browser_creator_impl.cc:815: !command_line_.HasSwitch(switches::kRemoteDebuggingPort)) { On 2017/02/11 03:57:09, Peter Kasting wrote: > ...
3 years ago (2017-02-13 18:14:17 UTC) #22
pfeldman
Sam, my understanding is that you are fine to land this. I will follow up ...
3 years ago (2017-02-13 18:26:59 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685203002/40001
3 years ago (2017-02-13 18:33:17 UTC) #26
Devlin
not lgtm. Sorry, but I don't think we can land this until we have some ...
3 years ago (2017-02-13 18:38:27 UTC) #27
pfeldman
Hey, Devlin, could you please keep me in the loop and resolve this in a ...
3 years ago (2017-02-13 18:40:28 UTC) #29
Devlin
3 years ago (2017-02-13 18:44:37 UTC) #30
On 2017/02/13 18:40:28, pfeldman wrote:
> Hey, Devlin, could you please keep me in the loop and resolve this in a timely
> manner?

Yep, will send out an email thread with us + others soon.

Powered by Google App Engine
This is Rietveld 408576698