Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2685183005: Makes ~InputMethodMus ack any in flight events (Closed)

Created:
3 years, 10 months ago by sky
Modified:
3 years, 10 months ago
Reviewers:
sadrul, Hadi
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes ~InputMethodMus ack any in flight events It's entirely possible for InputMethodMus to be awaiting a response from the ime server when deleted. If this happens the event ack to mus for the key event is never acked and mus won't process the next event until it times out. This patch makes ~InputMethodMus ack any in flight events immediately with unhandled. BUG=690709 TEST=covered by test R=moshayedi@chromium.org TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2685183005 Cr-Commit-Position: refs/heads/master@{#450039} Committed: https://chromium.googlesource.com/chromium/src/+/7a0d90d6351c104b896cb2ecef771dab00d68323

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : null #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -20 lines) Patch
M ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/mus/input_method_mus.h View 4 chunks +24 lines, -7 lines 0 comments Download
M ui/aura/mus/input_method_mus.cc View 1 2 7 chunks +30 lines, -11 lines 0 comments Download
A ui/aura/mus/input_method_mus_unittest.cc View 1 2 1 chunk +121 lines, -0 lines 0 comments Download
M ui/aura/mus/os_exchange_data_provider_mus_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
sky
3 years, 10 months ago (2017-02-11 00:30:11 UTC) #1
Hadi
Thanks for the CL. LGTM.
3 years, 10 months ago (2017-02-13 14:36:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685183005/40001
3 years, 10 months ago (2017-02-13 16:21:41 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-13 16:21:43 UTC) #14
sky
Hadi isn't a committer, so TBRing Sadrul.
3 years, 10 months ago (2017-02-13 17:29:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685183005/40001
3 years, 10 months ago (2017-02-13 17:30:48 UTC) #19
sadrul
lgtm
3 years, 10 months ago (2017-02-13 17:30:59 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 19:23:46 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7a0d90d6351c104b896cb2ecef77...

Powered by Google App Engine
This is Rietveld 408576698