components/favicon_base/favicon_types.h - Issue 2685173002: Extend LargeIconService to fetch missing favicons from a Google server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon_base/favicon_types.h

Issue 2685173002: Extend LargeIconService to fetch missing favicons from a Google server (Closed)

Patch Set: Peter's comments #2 (WIP) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon_base/favicon_types.h

diff --git a/components/favicon_base/favicon_types.h b/components/favicon_base/favicon_types.h

index 6a399cefe0ebb4e03e6000ea79e6480a60862805..1fe371d844dd4047e385f8c56c8b94ae1db82af1 100644

--- a/components/favicon_base/favicon_types.h

+++ b/components/favicon_base/favicon_types.h

@@ -85,8 +85,8 @@ typedef FaviconRawBitmapResult FaviconRawBitmapData;

struct LargeIconResult {

explicit LargeIconResult(const FaviconRawBitmapResult& bitmap_in);

- // Takes ownership of |fallback_icon_style_in|.

- explicit LargeIconResult(FallbackIconStyle* fallback_icon_style_in);

+ explicit LargeIconResult(

+ std::unique_ptr<FallbackIconStyle> fallback_icon_style_in);

~LargeIconResult();