components/favicon_base/favicon_types.cc - Issue 2685173002: Extend LargeIconService to fetch missing favicons from a Google server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon_base/favicon_types.cc

Issue 2685173002: Extend LargeIconService to fetch missing favicons from a Google server (Closed)

Patch Set: Peter's comments #2 (WIP) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon_base/favicon_types.cc

diff --git a/components/favicon_base/favicon_types.cc b/components/favicon_base/favicon_types.cc

index 8699c4387f4e85d79ee908b8dff3edccc52d268c..47b6b2a6e8cd6e8935e5621faec52d89745f9d60 100644

--- a/components/favicon_base/favicon_types.cc

+++ b/components/favicon_base/favicon_types.cc

@@ -33,8 +33,9 @@ FaviconRawBitmapResult::~FaviconRawBitmapResult() {}

LargeIconResult::LargeIconResult(const FaviconRawBitmapResult& bitmap_in)

: bitmap(bitmap_in) {}

-LargeIconResult::LargeIconResult(FallbackIconStyle* fallback_icon_style_in)

- : fallback_icon_style(fallback_icon_style_in) {}

+LargeIconResult::LargeIconResult(

+ std::unique_ptr<FallbackIconStyle> fallback_icon_style_in)

+ : fallback_icon_style(std::move(fallback_icon_style_in)) {}

LargeIconResult::~LargeIconResult() {}