Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2685163003: Avoid multiple displays of the sign-in dialogs. (Closed)

Created:
3 years, 10 months ago by msarda
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid multiple displays of the sign-in dialogs. This CL avoids diaplying the sync and the sign-in error dialogs if they were already displayed. BUG=685062 Review-Url: https://codereview.chromium.org/2685163003 Cr-Commit-Position: refs/heads/master@{#450112} Committed: https://chromium.googlesource.com/chromium/src/+/1100249acef2cfa42c46deb9279bbd864d7e8807

Patch Set 1 #

Patch Set 2 : Views #

Patch Set 3 : Ready for reviews #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
msarda
Please take a look.
3 years, 10 months ago (2017-02-10 12:11:58 UTC) #2
msarda
Jerome: I have tested this both on Linux and macOS and it works fine. Please ...
3 years, 10 months ago (2017-02-10 13:32:09 UTC) #3
jlebel
On 2017/02/10 13:32:09, msarda wrote: > Jerome: I have tested this both on Linux and ...
3 years, 10 months ago (2017-02-10 15:33:23 UTC) #4
jlebel
lgtm
3 years, 10 months ago (2017-02-10 15:33:55 UTC) #5
msarda
pkasting@chromium.org: Please take a look.
3 years, 10 months ago (2017-02-10 15:36:32 UTC) #7
Peter Kasting
c/b/ui/views LGTM
3 years, 10 months ago (2017-02-11 04:34:53 UTC) #12
msarda
Rohit: Please do an owners review for chrome/browser/ui/cocoa/profiles/ Thank you.
3 years, 10 months ago (2017-02-13 09:19:05 UTC) #14
rohitrao (ping after 24h)
cocoa LGTM
3 years, 10 months ago (2017-02-13 19:18:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685163003/40001
3 years, 10 months ago (2017-02-13 20:42:26 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 22:10:56 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1100249acef2cfa42c46deb9279b...

Powered by Google App Engine
This is Rietveld 408576698