Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2685133002:
[Resources] Remove unused strings in chrome/app/generated_resources.grd (Closed)
|
Created:
3 years, 10 months ago by Mathieu Modified:
3 years, 10 months ago Reviewers:
grt (UTC plus 2) CC:
chromium-reviews, srahim+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Resources] Remove unused strings in chrome/app/generated_resources.grd
Determined and removed by a script.
BUG=690075
TEST=builds
TBR=grt
Review-Url: https://codereview.chromium.org/2685133002
Cr-Commit-Position: refs/heads/master@{#449351}
Committed: https://chromium.googlesource.com/chromium/src/+/0b74c2d77dc4e670f783e68081141298acb4c642
Patch Set 1 : Initial #
Messages
Total messages: 22 (17 generated)
The CQ bit was checked by mathp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mathp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mathp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mathp@chromium.org changed reviewers: + grt@chromium.org
Hi Greg, can you take a look?
Description was changed from ========== [Resources] Remove unused strings in chrome/app/generated_resources.grd Determined and removed by a script. BUG=690075 TEST=builds ========== to ========== [Resources] Remove unused strings in chrome/app/generated_resources.grd Determined and removed by a script. BUG=690075 TEST=builds TBR=grt ==========
On 2017/02/09 16:55:37, Mathieu Perreault wrote: > Hi Greg, can you take a look? OWNERS file says to TBR, so I'll do that!
The CQ bit was checked by mathp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486663315526130,
"parent_rev": "a0c9d2388e2ad1d6e500befba0aa38af5bb4e9cb", "commit_rev":
"0b74c2d77dc4e670f783e68081141298acb4c642"}
Message was sent while issue was closed.
Description was changed from ========== [Resources] Remove unused strings in chrome/app/generated_resources.grd Determined and removed by a script. BUG=690075 TEST=builds TBR=grt ========== to ========== [Resources] Remove unused strings in chrome/app/generated_resources.grd Determined and removed by a script. BUG=690075 TEST=builds TBR=grt Review-Url: https://codereview.chromium.org/2685133002 Cr-Commit-Position: refs/heads/master@{#449351} Committed: https://chromium.googlesource.com/chromium/src/+/0b74c2d77dc4e670f783e6808114... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/0b74c2d77dc4e670f783e6808114...
Message was sent while issue was closed.
a hearty rubberstamp lgtm! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
