Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2685073002: Make GRIT not to generate const struct members (Closed)

Created:
3 years, 10 months ago by sabbakumov
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GRIT not to generate const struct members chrome.dll: .text: 16 bytes change .rdata: 25376 bytes change .data: -25536 bytes change .reloc: 128 bytes change Total change: -16 bytes BUG=677351 Review-Url: https://codereview.chromium.org/2685073002 Cr-Commit-Position: refs/heads/master@{#453145} Committed: https://chromium.googlesource.com/chromium/src/+/b7c41be9c2235fa51c1e6e0abd3963d277cc1df2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/grit/grit/format/resource_map.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/grit/grit/format/resource_map_unittest.py View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sabbakumov
3 years, 10 months ago (2017-02-09 02:49:43 UTC) #3
Lei Zhang
lgtm
3 years, 10 months ago (2017-02-23 19:33:28 UTC) #4
Lei Zhang
Please note the status message embedded in user names. I was away for a while, ...
3 years, 10 months ago (2017-02-23 19:34:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685073002/1
3 years, 9 months ago (2017-02-27 04:27:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b7c41be9c2235fa51c1e6e0abd3963d277cc1df2
3 years, 9 months ago (2017-02-27 04:32:38 UTC) #14
brucedawson
3 years, 9 months ago (2017-02-27 18:41:12 UTC) #15
Message was sent while issue was closed.
Hey, that's great. That moves a *lot* of globals to the read-only data segment.
I think that now the vast majority of the globals that should be in the
read-only segment are, although I'm still going to run another report just to
see, with tomorrow's canary.

Powered by Google App Engine
This is Rietveld 408576698