Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2685023002: XS: Use the correct enum value for SUBRESOURCE_FILTER (Closed)

Created:
3 years, 10 months ago by vakh (use Gerrit instead)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vakh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct enum value for SUBRESOURCE_FILTER The internal proto uses value 13 for SUBRESOURCE_FILTER so Chromium should use the same value. BUG=690071 Review-Url: https://codereview.chromium.org/2685023002 Cr-Commit-Position: refs/heads/master@{#449058} Committed: https://chromium.googlesource.com/chromium/src/+/d0827cde83fe81c9731090ce01e7ce34e6d4b9b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/safe_browsing_db/safebrowsing.proto View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
vakh (use Gerrit instead)
3 years, 10 months ago (2017-02-08 17:56:03 UTC) #4
melandory
On 2017/02/08 17:56:03, vakh (Varun Khaneja) wrote: lgtm (sorry, I thought I updated it, but ...
3 years, 10 months ago (2017-02-08 18:02:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685023002/1
3 years, 10 months ago (2017-02-08 18:03:15 UTC) #7
woz
lgtm
3 years, 10 months ago (2017-02-08 18:42:20 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 19:17:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0827cde83fe81c9731090ce01e7...

Powered by Google App Engine
This is Rietveld 408576698