Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2685003002: Rename ScreeManagerOzone to ScreenManagerOzoneInternal (Closed)

Created:
3 years, 10 months ago by tonikitoo
Modified:
3 years, 10 months ago
Reviewers:
rjkroege, kylechar
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScreeManagerOzone to ScreenManagerOzoneInternal CL renames ScreeManagerOzone to ScreenManagerOzoneInternal, and ScreeManagerStub to ScreenManagerStubInternal to reflect their current 'internal window mode' purposes. Eventually, we will have a ScreenManagerOzoneExternal class, which should support 'external window mode' with Mus. BUG=666958 Review-Url: https://codereview.chromium.org/2685003002 Cr-Commit-Position: refs/heads/master@{#449168} Committed: https://chromium.googlesource.com/chromium/src/+/d30059398a5b1f1d09ad437c9f9def392c605790

Patch Set 1 #

Patch Set 2 : fixed display_service_unittests target build #

Patch Set 3 : addressed kylechar/rjkroege's feedback #

Total comments: 2

Patch Set 4 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1012 lines) Patch
M services/ui/display/BUILD.gn View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
D services/ui/display/screen_manager_ozone.h View 1 chunk +0 lines, -124 lines 0 comments Download
D services/ui/display/screen_manager_ozone.cc View 1 chunk +0 lines, -396 lines 0 comments Download
A + services/ui/display/screen_manager_ozone_internal.h View 1 2 3 5 chunks +11 lines, -10 lines 0 comments Download
A + services/ui/display/screen_manager_ozone_internal.cc View 1 2 14 chunks +36 lines, -34 lines 0 comments Download
A + services/ui/display/screen_manager_ozone_internal_unittests.cc View 1 2 9 chunks +14 lines, -14 lines 0 comments Download
D services/ui/display/screen_manager_ozone_unittests.cc View 1 chunk +0 lines, -285 lines 0 comments Download
D services/ui/display/screen_manager_stub.h View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D services/ui/display/screen_manager_stub.cc View 1 2 1 chunk +0 lines, -78 lines 0 comments Download
A + services/ui/display/screen_manager_stub_internal.h View 1 2 3 chunks +10 lines, -9 lines 0 comments Download
A + services/ui/display/screen_manager_stub_internal.cc View 1 2 3 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 31 (19 generated)
tonikitoo
PTAL
3 years, 10 months ago (2017-02-08 17:08:50 UTC) #4
fwang
informal l g t m
3 years, 10 months ago (2017-02-08 17:12:11 UTC) #5
rjkroege
On 2017/02/08 17:12:11, fwang wrote: > informal l g t m Apologies for being difficult. ...
3 years, 10 months ago (2017-02-08 19:20:56 UTC) #11
tonikitoo
On 2017/02/08 19:20:56, rjkroege wrote: > On 2017/02/08 17:12:11, fwang wrote: > > informal l ...
3 years, 10 months ago (2017-02-08 19:24:21 UTC) #12
kylechar
On 2017/02/08 19:24:21, tonikitoo wrote: > On 2017/02/08 19:20:56, rjkroege wrote: > > On 2017/02/08 ...
3 years, 10 months ago (2017-02-08 20:00:23 UTC) #15
tonikitoo
On 2017/02/08 20:00:23, kylechar wrote: > On 2017/02/08 19:24:21, tonikitoo wrote: > > On 2017/02/08 ...
3 years, 10 months ago (2017-02-08 20:19:52 UTC) #16
tonikitoo
On 2017/02/08 20:00:23, kylechar wrote: > On 2017/02/08 19:24:21, tonikitoo wrote: > > On 2017/02/08 ...
3 years, 10 months ago (2017-02-08 20:48:12 UTC) #18
rjkroege
lgtm https://codereview.chromium.org/2685003002/diff/40001/services/ui/display/screen_manager_ozone_internal.h File services/ui/display/screen_manager_ozone_internal.h (right): https://codereview.chromium.org/2685003002/diff/40001/services/ui/display/screen_manager_ozone_internal.h#newcode35 services/ui/display/screen_manager_ozone_internal.h:35: // attached physical displays on the ozone platform. ...
3 years, 10 months ago (2017-02-08 21:56:32 UTC) #21
tonikitoo
https://codereview.chromium.org/2685003002/diff/40001/services/ui/display/screen_manager_ozone_internal.h File services/ui/display/screen_manager_ozone_internal.h (right): https://codereview.chromium.org/2685003002/diff/40001/services/ui/display/screen_manager_ozone_internal.h#newcode35 services/ui/display/screen_manager_ozone_internal.h:35: // attached physical displays on the ozone platform. On ...
3 years, 10 months ago (2017-02-08 23:39:39 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685003002/60001
3 years, 10 months ago (2017-02-08 23:40:22 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/d30059398a5b1f1d09ad437c9f9def392c605790
3 years, 10 months ago (2017-02-09 00:59:01 UTC) #30
kylechar
3 years, 10 months ago (2017-02-09 14:06:09 UTC) #31
Message was sent while issue was closed.
a little late but lgtm.

Powered by Google App Engine
This is Rietveld 408576698